[SPARK-42003][SQL] Reduce duplicate code in ResolveGroupByAll #39523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Jan 12, 2023
|
thanks, merging to master! |
vicennial
pushed a commit
to vicennial/spark
that referenced
this pull request
Jan 17, 2023
### What changes were proposed in this pull request? Reduce duplicate code in ResolveGroupByAll by moving the group by expression inference into a new method. ### Why are the changes needed? Code clean up ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT Closes apache#39523 from gengliangwang/refactorAll. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reduce duplicate code in ResolveGroupByAll by moving the group by expression inference into a new method.
Why are the changes needed?
Code clean up
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT