[SPARK-41970][SQL][FOLLOWUP] Revert SparkPath changes to FileIndex and FileRelation #39808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
databricks-david-lewis
changed the title
SparkPath -> String
databricks-david-lewis
force-pushed
the
SPARK_PATH_FOLLOWUP
branch
from
8f1c9bb
to
1102f05
Compare
There was a problem hiding this comment.
Is this a partial revert, @databricks-david-lewis ?
cc @cloud-fan and @HyukjinKwon and @xinrong-meng
|
Yes it is @dongjoon-hyun. |
| override def inputFiles: Array[SparkPath] = | ||
| allFiles().map(SparkPath.fromFileStatus).toArray | ||
| override def inputFiles: Array[String] = | ||
| allFiles().map(fs => SparkPath.fromFileStatus(fs).urlEncoded).toArray |
There was a problem hiding this comment.
So, this part is not reverting to the original code, allFiles().map(_.getPath.toUri.toString).toArray, right?
There was a problem hiding this comment.
Ah good point. It is not exactly a revert, but is reusing the SparkPath code to translate from hadoop FileStatus to url-encoded string.
dongjoon-hyun
approved these changes
Jan 30, 2023
|
Also, cc @sunchao |
HyukjinKwon
approved these changes
Jan 31, 2023
HyukjinKwon
changed the title
HyukjinKwon
changed the title
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 31, 2023
…d FileRelation ### What changes were proposed in this pull request? This PR reverts the `SparkPath`changes to `FileIndex` and `FileRelation` because they provided little benefit to Open Source Spark, but are widely used extension points for other open source projects. For the 3.4.0 release we want to preserve this type of binary compatibility. That said, we reserve the right to make this change for Spark 4.0. ### Why are the changes needed? Revert `inputFiles: Array[SparkPath]` back to `inputFiles: Array[String]`, with an explicit comment that the strings are expected to be url-encoded. ### Does this PR introduce _any_ user-facing change? This is to revert an internal interface change. ### How was this patch tested? Existing unit tests. Closes #39808 from databricks-david-lewis/SPARK_PATH_FOLLOWUP. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 3887e71) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
|
late LGTM |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…d FileRelation ### What changes were proposed in this pull request? This PR reverts the `SparkPath`changes to `FileIndex` and `FileRelation` because they provided little benefit to Open Source Spark, but are widely used extension points for other open source projects. For the 3.4.0 release we want to preserve this type of binary compatibility. That said, we reserve the right to make this change for Spark 4.0. ### Why are the changes needed? Revert `inputFiles: Array[SparkPath]` back to `inputFiles: Array[String]`, with an explicit comment that the strings are expected to be url-encoded. ### Does this PR introduce _any_ user-facing change? This is to revert an internal interface change. ### How was this patch tested? Existing unit tests. Closes apache#39808 from databricks-david-lewis/SPARK_PATH_FOLLOWUP. Authored-by: David Lewis <david.lewis@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 3887e71) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reverts the
SparkPathchanges toFileIndexandFileRelationbecause they provided little benefit to Open Source Spark, but are widely used extension points for other open source projects. For the 3.4.0 release we want to preserve this type of binary compatibility.That said, we reserve the right to make this change for Spark 4.0.
Why are the changes needed?
Revert
inputFiles: Array[SparkPath]back toinputFiles: Array[String], with an explicit comment that the strings are expected to be url-encoded.Does this PR introduce any user-facing change?
This is to revert an internal interface change.
How was this patch tested?
Existing unit tests.