SPARK-5019 [MLlib] - GaussianMixtureModel exposes instances of MultivariateGauss... #4088
Conversation
…ussian rather than mean/covariance matrices
|
Test build #25707 has started for PR 4088 at commit
|
|
Test build #25707 has finished for PR 4088 at commit
|
|
Test PASSed. |
tgaloppo
changed the title
| @@ -37,8 +37,9 @@ import org.apache.spark.mllib.util.MLUtils | |||
| */ | |||
| class GaussianMixtureModel( | |||
| val weight: Array[Double], | |||
| val mu: Array[Vector], | |||
| val sigma: Array[Matrix]) extends Serializable { | |||
| val gaussian: Array[MultivariateGaussian]) extends Serializable { | |||
There was a problem hiding this comment.
Should "weight" and "gaussian" be plural ("weights" and "gaussians")?
|
@tgaloppo Other than the 1 comment, this looks good. Thanks! |
… gaussians. Other sources modified accordingly.
|
Test build #25786 has started for PR 4088 at commit
|
|
@jkbradley I considered making those plural for the initial commit. I guess I should have. Update has been made. |
|
Test build #25786 has finished for PR 4088 at commit
|
|
Test PASSed. |
|
Merged into master. Thanks! |
…ariateGauss... This PR modifies GaussianMixtureModel to expose instances of MutlivariateGaussian rather than separate mean and covariance arrays. Author: Travis Galoppo <tjg2107@columbia.edu> Closes apache#4088 from tgaloppo/spark-5019 and squashes the following commits: 3ef6c7f [Travis Galoppo] In GaussianMixtureModel: Changed name of weight, gaussian to weights, gaussians. Other sources modified accordingly. 091e8da [Travis Galoppo] SPARK-5019 - GaussianMixtureModel exposes instances of MultivariateGaussian rather than mean/covariance matrices
This PR modifies GaussianMixtureModel to expose instances of MutlivariateGaussian rather than separate mean and covariance arrays.