[SPARK-38464][CORE] Use error classes in org.apache.spark.io #41277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
requested changes
May 23, 2023
| errorClass = "CODEC_NOT_AVAILABLE", | ||
| messageParameters = Map( | ||
| "codecName" -> codecName, | ||
| "configKey" -> configKey, |
There was a problem hiding this comment.
Ditto. Should we move these to spark-core? Or have them duplicated?
There was a problem hiding this comment.
Oh, sorry. Let's define in core at leats quoteByDefault(), toConf, and toConfVal.
| messageParameters = Map( | ||
| "codecName" -> codecName, | ||
| "configKey" -> configKey, | ||
| "configVal" -> FALLBACK_COMPRESSION_CODEC))) |
There was a problem hiding this comment.
Could you wrap it by toSQLConfVal
core/src/test/scala/org/apache/spark/io/CompressionCodecSuite.scala
Outdated
Show resolved
Hide resolved
| codec.getOrElse(throw new SparkIllegalArgumentException( | ||
| errorClass = "CODEC_NOT_AVAILABLE", | ||
| messageParameters = Map( | ||
| "codecName" -> codecName, |
There was a problem hiding this comment.
Please, wrap it, for instance by toSQLValue
There was a problem hiding this comment.
toSQLValue is defined in spark-sql, we cannot use it directly here in spark-core.
MaxGekk
approved these changes
May 24, 2023
|
+1, LGTM. Merging to master. |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request? This PR aims to change exceptions created in package org.apache.spark.io to use error class. This PR also adds `toConf` and `toConfVal` in `SparkCoreErrors`. ### Why are the changes needed? This is to move exceptions created in package org.apache.spark.io to error class. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Updated existing tests. Closes apache#41277 from bozhang2820/spark-38464. Authored-by: Bo Zhang <bo.zhang@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to change exceptions created in package org.apache.spark.io to use error class.
This PR also adds
toConfandtoConfValinSparkCoreErrors.Why are the changes needed?
This is to move exceptions created in package org.apache.spark.io to error class.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Updated existing tests.