Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43928][SQL][TESTS][FOLLOWUP] Remove getbit from excludedSqlFunctions to fix DataFrame function and SQL function parity #41639

Closed
wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Jun 17, 2023

What changes were proposed in this pull request?

This pr remove getbit from excludedSqlFunctions to make DataFrame function and SQL functon parity in DataFrameFunctionsSuite test pass. These function were introduced into sql.functions in #41608 and need to maintain the content of excludedSqlFunctions simultaneously.

Why are the changes needed?

Fix DataFrame function and SQL function parity in DataFrameFunctionsSuite

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Acitons
  • Manual check, run
build/sbt "sql/testOnly *DataFrameFunctionsSuite"

Before

[info] - DataFrame function and SQL functon parity *** FAILED *** (679 milliseconds)
[info]   Set("getbit") was not empty (DataFrameFunctionsSuite.scala:115)
[info]   org.scalatest.exceptions.TestFailedException:
[info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info]   at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info]   at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info]   at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info]   at org.apache.spark.sql.DataFrameFunctionsSuite.$anonfun$new$1(DataFrameFunctionsSuite.scala:115)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:226)
[info]   at org.apache.spark.SparkFunSuite.withFixture(SparkFunSuite.scala:221)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.invokeWithFixture$1(AnyFunSuiteLike.scala:224)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTest$1(AnyFunSuiteLike.scala:236)
[info]   at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.runTest(AnyFunSuiteLike.scala:236)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.runTest$(AnyFunSuiteLike.scala:218)
[info]   at org.apache.spark.SparkFunSuite.org$scalatest$BeforeAndAfterEach$$super$runTest(SparkFunSuite.scala:67)
[info]   at org.scalatest.BeforeAndAfterEach.runTest(BeforeAndAfterEach.scala:234)
[info]   at org.scalatest.BeforeAndAfterEach.runTest$(BeforeAndAfterEach.scala:227)
[info]   at org.apache.spark.SparkFunSuite.runTest(SparkFunSuite.scala:67)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$runTests$1(AnyFunSuiteLike.scala:269)
[info]   at org.scalatest.SuperEngine.$anonfun$runTestsInBranch$1(Engine.scala:413)
[info]   at scala.collection.immutable.List.foreach(List.scala:431)
[info]   at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:401)
[info]   at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:396)
[info]   at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:475)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.runTests(AnyFunSuiteLike.scala:269)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.runTests$(AnyFunSuiteLike.scala:268)
[info]   at org.scalatest.funsuite.AnyFunSuite.runTests(AnyFunSuite.scala:1564)
[info]   at org.scalatest.Suite.run(Suite.scala:1114)
[info]   at org.scalatest.Suite.run$(Suite.scala:1096)
[info]   at org.scalatest.funsuite.AnyFunSuite.org$scalatest$funsuite$AnyFunSuiteLike$$super$run(AnyFunSuite.scala:1564)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.$anonfun$run$1(AnyFunSuiteLike.scala:273)
[info]   at org.scalatest.SuperEngine.runImpl(Engine.scala:535)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.run(AnyFunSuiteLike.scala:273)
[info]   at org.scalatest.funsuite.AnyFunSuiteLike.run$(AnyFunSuiteLike.scala:272)
[info]   at org.apache.spark.SparkFunSuite.org$scalatest$BeforeAndAfterAll$$super$run(SparkFunSuite.scala:67)
[info]   at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:213)
[info]   at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:210)
[info]   at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:208)
[info]   at org.apache.spark.SparkFunSuite.run(SparkFunSuite.scala:67)
[info]   at org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:321)
[info]   at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:517)
[info]   at sbt.ForkMain$Run.lambda$runTest$1(ForkMain.java:413)
[info]   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[info]   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[info]   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[info]   at java.lang.Thread.run(Thread.java:750)
...
[info] Run completed in 32 seconds, 734 milliseconds.
[info] Total number of tests run: 135
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 134, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***

After

[info] Run completed in 32 seconds, 441 milliseconds.
[info] Total number of tests run: 135
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 135, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

@LuciferYang
Copy link
Contributor Author

@LuciferYang LuciferYang changed the title [SPARK-43928][SQL][TESTS][FOLLOWUP] Fix DataFrameFunctionsSuite [SPARK-43928][SQL][TESTS][FOLLOWUP] Remove getbit from excludedSqlFunctions to fix DataFrame function and SQL function parity in DataFrameFunctionsSuite Jun 17, 2023
@LuciferYang LuciferYang changed the title [SPARK-43928][SQL][TESTS][FOLLOWUP] Remove getbit from excludedSqlFunctions to fix DataFrame function and SQL function parity in DataFrameFunctionsSuite [SPARK-43928][SQL][TESTS][FOLLOWUP] Remove getbit from excludedSqlFunctions to fix DataFrame function and SQL function parity in DataFrameFunctionsSuite Jun 17, 2023
@LuciferYang LuciferYang changed the title [SPARK-43928][SQL][TESTS][FOLLOWUP] Remove getbit from excludedSqlFunctions to fix DataFrame function and SQL function parity in DataFrameFunctionsSuite [SPARK-43928][SQL][TESTS][FOLLOWUP] Remove getbit from excludedSqlFunctions to fix DataFrame function and SQL function parity Jun 17, 2023
@panbingkun
Copy link
Contributor

LGTM, I just discovered this issue, haha.

@zhengruifeng
Copy link
Contributor

thanks for the catch, the sql - other failed before this again ...

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants