[SPARK-43928][SQL][PYTHON][CONNECT][FOLLOWUP] Update excludedSqlFunctions of DataFrameFunctionsSuite
#41640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions of DataFrameFunctionsSuite
|
ping @zhengruifeng cc @LuciferYang |
LuciferYang
approved these changes
Jun 17, 2023
|
OK, let me close #41639 |
|
@LuciferYang Because the issue is my fault. Let me fix it. Thank you! |
beliefer
changed the title
excludedSqlFunctions of DataFrameFunctionsSuite
|
LGTM |
panbingkun
approved these changes
Jun 17, 2023
zhengruifeng
approved these changes
Jun 17, 2023
|
I manually check this fix in my local env merged to master |
|
maybe we should move |
Yeah. The |
|
Thank you, @beliefer and all! |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 19, 2023
…tions` of `DataFrameFunctionsSuite` ### What changes were proposed in this pull request? apache#41608 add bit operations to Scala, Python and Connect API, but missing the test for `DataFrameFunctionsSuite`. ### Why are the changes needed? Fix missing tests ### Does this PR introduce _any_ user-facing change? 'No'. New feature. ### How was this patch tested? N/A Closes apache#41640 from beliefer/SPARK-43928_followup. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#41608 add bit operations to Scala, Python and Connect API, but missing the test for
DataFrameFunctionsSuite.Why are the changes needed?
Fix missing tests
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
N/A