Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3298][SQL] Add flag control overwrite registerAsTable / registerTempTable #4175

Closed
wants to merge 0 commits into from

Conversation

OopsOutOfMemory
Copy link
Contributor

https://issues.apache.org/jira/browse/SPARK-3298

add a flag allowOverwrite to control overwrite registerTempTable.

By default it is true means registerTempTable command will overwrite the previous table has same name.
(like var tempTable)

If set it to false, means the registerTempTable command will check the same name table exists in catalog or not and if exists throw a table already exists exception.
(like final tempTable)

You could drop it first and then register it again.

@OopsOutOfMemory
Copy link
Contributor Author

@marmbrus Any comments here ?

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@OopsOutOfMemory
Copy link
Contributor Author

/cc @scwf @chenghao-intel

@squito
Copy link
Contributor

squito commented Jan 25, 2015

Jenkins this is OK to test

@squito
Copy link
Contributor

squito commented Jan 25, 2015

this is mentioned in the jira, but its worth noting again here that this changes the behavior slightly, since it wouldn't throw an exception before.

@squito
Copy link
Contributor

squito commented Jan 25, 2015

lets try this again ...
Jenkins this is OK to test

@squito
Copy link
Contributor

squito commented Jan 26, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Jan 26, 2015

Test build #26119 has started for PR 4175 at commit 9538bfe.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 26, 2015

Test build #26119 has finished for PR 4175 at commit 9538bfe.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26119/
Test FAILed.

@squito
Copy link
Contributor

squito commented Jan 27, 2015

I think these failures are real, looks like you need to do a similar updating of the args to registerTempTable in the pyspark tests, eg. here

there are more places too, look in the test console output for the full list

@OopsOutOfMemory
Copy link
Contributor Author

Thanks, squito :)
I'm working on this issue.

@SparkQA
Copy link

SparkQA commented Jan 27, 2015

Test build #26141 has started for PR 4175 at commit 26c6011.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 27, 2015

Test build #26141 has finished for PR 4175 at commit 26c6011.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26141/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants