Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45278] [YARN] Allow configuring Yarn executor bind address in Yarn #42870

Closed
wants to merge 11 commits into from

Conversation

gedeh
Copy link

@gedeh gedeh commented Sep 11, 2023

What changes were proposed in this pull request?

Uptake --bind-address parameter in YarnCoarseGrainedExecutorBackend when launching new container in Yarn cluster. This PR also ensure YarnAllocator uses default hostname when its not configured.

Why are the changes needed?

We've came across istio/istio#27900 with Spark running on Yarn in Istio enabled Kubernetes cluster. Previous PR #32633 is not merged because Spark 2.4 was EOL.

Does this PR introduce any user-facing change?

Yes, new config specifically for Yarn cluster mode is added and relevant doc is updated.

How was this patch tested?

Tested in Kubenetes with Istio and added tests to YarnAllocatorSuite

Thanks!

@gedeh gedeh changed the title SPARK-29670][CORE] Allow configuring Yarn executor bind address [SPARK-29670][CORE] Allow configuring Yarn executor bind address Sep 11, 2023
@gedeh
Copy link
Author

gedeh commented Sep 11, 2023

Apologies using old Jira because I am unable to raise new Spark Jira in ASF

@gedeh gedeh changed the title [SPARK-29670][CORE] Allow configuring Yarn executor bind address [SPARK-24203][CORE] Allow configuring Yarn executor bind address Sep 11, 2023
@gedeh gedeh changed the title [SPARK-24203][CORE] Allow configuring Yarn executor bind address [SPARK-24203][CORE] Allow configuring Yarn executor bind address in Yarn Sep 11, 2023
@gedeh
Copy link
Author

gedeh commented Sep 11, 2023

Latest full test run via Github Action https://github.com/gedeh/spark/actions/runs/6143764745

@gedeh gedeh changed the title [SPARK-24203][CORE] Allow configuring Yarn executor bind address in Yarn [YARN] Allow configuring Yarn executor bind address in Yarn Sep 18, 2023
@gedeh
Copy link
Author

gedeh commented Sep 18, 2023

@srowen and @dongjoon-hyun you were on previous PR #32633
Apologies I can't raise new Jira in Spark project for this issue

@srowen
Copy link
Member

srowen commented Sep 18, 2023

Can you remove the unrelated changes?
Do you have a JIRA account? You can request one on the JIRA site.

@gedeh
Copy link
Author

gedeh commented Sep 18, 2023

Thank you for the prompt reply @srowen

Can you remove the unrelated changes?

Which changes these will be? Are you suggesting the changes in docs/configuration.md?

Do you have a JIRA account? You can request one on the JIRA site.

I requested an account few days ago, but unfortunately the request rejected

@gedeh gedeh marked this pull request as ready for review September 20, 2023 10:55
@gedeh gedeh changed the title [YARN] Allow configuring Yarn executor bind address in Yarn [SPARK-45278] [YARN] Allow configuring Yarn executor bind address in Yarn Sep 22, 2023
@gedeh
Copy link
Author

gedeh commented Sep 22, 2023

@srowen got my ASF account created and raised this Jira https://issues.apache.org/jira/browse/SPARK-45278. Removed the change in configuration.md file too. Thanks in advance

<td><code>spark.yarn.executor.bindAddress</code></td>
<td><code>(executor hostname)</code></td>
<td>
Hostname or IP address where to bind listening sockets in YARN cluster mode.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why YARN cluster mode? The change affects client mode as well, doesn't it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm true, will benefit client mode as well

Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Feb 19, 2024
@github-actions github-actions bot closed this Feb 20, 2024
@gedeh
Copy link
Author

gedeh commented Mar 6, 2024

Hello, I noticed this PR is closed, this is blocking Spark with Yarn in kubernetes. I dont understand whats left missing for this PR. If anyone in Spark project can shed a light what required to merge this for next release of Spark that would be great. Thanks!

@laocoder2014
Copy link

laocoder2014 commented Mar 25, 2024

I think this PR is needed for Spark to work under Istio/service mesh. I am just wondering if anyone has run Spark/YARN successfully under Istio/Service Mesh.
The PR Spark-26331 was merged and made the 'executor's bindAddress' configurable. But without the above PR, how can user configure the executor's bindAddress?
@srowen @tokoko Can you look into this PR? Can you reopen/merge it?

@gedeh
Copy link
Author

gedeh commented Aug 27, 2024

I think this PR is needed for Spark to work under Istio/service mesh. I am just wondering if anyone has run Spark/YARN successfully under Istio/Service Mesh. The PR Spark-26331 was merged and made the 'executor's bindAddress' configurable. But without the above PR, how can user configure the executor's bindAddress? @srowen @tokoko Can you look into this PR? Can you reopen/merge it?

I've created new PR #47892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants