-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-45278] [YARN] Allow configuring Yarn executor bind address in Yarn #42870
Conversation
Apologies using old Jira because I am unable to raise new Spark Jira in ASF |
Latest full test run via Github Action https://github.com/gedeh/spark/actions/runs/6143764745 |
@srowen and @dongjoon-hyun you were on previous PR #32633 |
Can you remove the unrelated changes? |
Thank you for the prompt reply @srowen
Which changes these will be? Are you suggesting the changes in
I requested an account few days ago, but unfortunately the request rejected |
89d54d3
to
dad8c5d
Compare
@srowen got my ASF account created and raised this Jira https://issues.apache.org/jira/browse/SPARK-45278. Removed the change in |
<td><code>spark.yarn.executor.bindAddress</code></td> | ||
<td><code>(executor hostname)</code></td> | ||
<td> | ||
Hostname or IP address where to bind listening sockets in YARN cluster mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why YARN cluster mode
? The change affects client mode as well, doesn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm true, will benefit client
mode as well
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Hello, I noticed this PR is closed, this is blocking Spark with Yarn in kubernetes. I dont understand whats left missing for this PR. If anyone in Spark project can shed a light what required to merge this for next release of Spark that would be great. Thanks! |
I think this PR is needed for Spark to work under Istio/service mesh. I am just wondering if anyone has run Spark/YARN successfully under Istio/Service Mesh. |
I've created new PR #47892 |
What changes were proposed in this pull request?
Uptake
--bind-address
parameter inYarnCoarseGrainedExecutorBackend
when launching new container in Yarn cluster. This PR also ensureYarnAllocator
uses default hostname when its not configured.Why are the changes needed?
We've came across istio/istio#27900 with Spark running on Yarn in Istio enabled Kubernetes cluster. Previous PR #32633 is not merged because Spark 2.4 was EOL.
Does this PR introduce any user-facing change?
Yes, new config specifically for Yarn cluster mode is added and relevant doc is updated.
How was this patch tested?
Tested in Kubenetes with Istio and added tests to
YarnAllocatorSuite
Thanks!