New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-44442][MESOS] Remove Mesos support #43135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 lines more, and it would have been an event 10k lines removed :-)
A satisfying operation, hahaha ~ |
spark/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala Lines 814 to 831 in f6c6acb
Does this part need to be fixed? |
In addition, does this line of comment still need to be retained? |
I noticed the TaskState.LOST comment, but was reluctant to actually totally remove handling of this event in case the comment was wrong. |
fine to me |
It looks like the tests actually passed but showing failed - I'm not quite sure what to make of the failure in 'reporting results'. |
Merged to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, late LGTM.
…il.Utils#getConfiguredLocalDirs` ### What changes were proposed in this pull request? This PR cleans up an unused local variables from `org.apache.spark.util.Utils#getConfiguredLocalDirs` function, It is no longer used after the support for Mesos was removed in SPARK-44442 (#43135). ### Why are the changes needed? Code clean up ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #44475 from LuciferYang/utils-useless. Lead-authored-by: yangjie01 <yangjie01@baidu.com> Co-authored-by: YangJie <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
Remove Mesos resource manager support and docs, previously deprecated in Spark 3.2, for Spark 4.0.
Why are the changes needed?
Mesos is no longer supported and has been deprecated for several versions.
Does this PR introduce any user-facing change?
Other than the lack of Mesos support, no
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No