-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-46498][CORE] Remove shuffleServiceEnabled
from o.a.spark.util.Utils#getConfiguredLocalDirs
#44475
Conversation
o.a.spark.util.Utils
o.a.spark.util.Utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but let's not remove these Utils
methods although they are private[spark]
. There is no maintenance overhead for these util methods and these might be used by a new repository Spark Operator
which is voted recently.
@@ -769,7 +769,6 @@ private[spark] object Utils | |||
* logic of locating the local directories according to deployment mode. | |||
*/ | |||
def getConfiguredLocalDirs(conf: SparkConf): Array[String] = { | |||
val shuffleServiceEnabled = conf.get(config.SHUFFLE_SERVICE_ENABLED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, this is enough for a valid PR. We can merge if we have only this removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
o.a.spark.util.Utils
o.a.spark.util.Utils#getConfiguredLocalDirs
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you for updating this PR.
o.a.spark.util.Utils#getConfiguredLocalDirs
shuffleServiceEnabled
from o.a.spark.util.Utils#getConfiguredLocalDirs
Thanks @dongjoon-hyun ~ |
What changes were proposed in this pull request?
This PR cleans up an unused local variables from
org.apache.spark.util.Utils#getConfiguredLocalDirs
function, It is no longer used after the support for Mesos was removed in SPARK-44442 (#43135).Why are the changes needed?
Code clean up
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No