[SPARK-44751][SQL][FOLLOW-UP] Move XSDToSchema from catalyst to core package
#43652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b5becdd.
HyukjinKwon
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
LGTM but mind retriggering https://github.com/shujingyang-db/spark/actions/runs/6750039898/job/18351672725 to make sure?
dongjoon-hyun
changed the title
XSDToSchema from catalyst to core package
|
tests passed at https://github.com/shujingyang-db/spark/actions/runs/6750039898 Merged to master. |
HyukjinKwon
changed the title
XSDToSchema from catalyst to core packageXSDToSchema from catalyst to core package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move XSDToSchema from catalyst to core package
Why are the changes needed?
It facilitates the a follow-up refactoring PR.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No