[SPARK-45845][SS][UI] Add number of evicted state rows to streaming UI #43723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HeartSaVioR can you take a look please : ) |
HeartSaVioR
reviewed
Nov 10, 2023
| <tr> | ||
| <td style="vertical-align: middle;"> | ||
| <div style="width: 160px;"> | ||
| <div><strong>Aggregated Number Of Evicted State Rows{SparkUIUtils.tooltip("Aggregated number of state rows evicted from the state.", "right")}</strong></div> |
There was a problem hiding this comment.
Let's use the word "removed" than "evicted" - it is "also" fit to the case where you manually remove the state in flatMapGroupsWithState. The semantic of "eviction" does not cover such case.
HeartSaVioR
reviewed
Nov 10, 2023
HeartSaVioR
reviewed
Nov 12, 2023
sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatisticsPage.scala
Outdated
Show resolved
Hide resolved
|
https://github.com/WweiL/oss-spark/actions/runs/6829179497/job/18579693008 Could you please check with UISeleniumSuite and confirm that it's not related to this change? |
|
@HeartSaVioR Thanks for pointing it out! Yes the two UISeleniumSuite related ones are indeed caused by this PR. I verified locally that they don't fail after my new commit |
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In a stateful query, a watermark has two responsibilities:
Before we only log "aggregated number of rows dropped by watermark". This is case 1. But people would confuse this with case 2. This PR purpose we also add a chart for case 2. Also made the explanation for case 1 more verbose.
Now:
Why are the changes needed?
UI improvement
Does this PR introduce any user-facing change?
Yes, users will be able to view the new UI
How was this patch tested?
Manually tested
Was this patch authored or co-authored using generative AI tooling?
No