[SPARK-46205][CORE][TESTS][FOLLOWUP] Simplify PersistenceEngineBenchmark #44118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @beliefer . This is the follow-up PR for your comment. |
dongjoon-hyun
force-pushed
the
SPARK-46205-2
branch
from
24c067c
to
9448e3e
Compare
|
Could you review this PR, @LuciferYang ? |
LuciferYang
approved these changes
Dec 2, 2023
|
Thank you, @LuciferYang . Merged to master. |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
### What changes were proposed in this pull request? This is a follow-up of apache#44113 to address a comment about simplifying the benchmark. ### Why are the changes needed? To simplify. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually. ``` $ build/sbt "core/Test/runMain org.apache.spark.deploy.master.PersistenceEngineBenchmark" ... [info] OpenJDK 64-Bit Server VM 17.0.9+9-LTS on Mac OS X 14.2 [info] Apple M1 Max [info] 1000 Workers: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative [info] ------------------------------------------------------------------------------------------------------------------------------- [info] ZooKeeperPersistenceEngine with JavaSerializer 12602 12847 253 0.0 12601717.5 1.0X [info] ZooKeeperPersistenceEngine with KryoSerializer 12116 12130 13 0.0 12116373.8 1.0X [info] FileSystemPersistenceEngine with JavaSerializer 429 435 6 0.0 429374.9 29.3X [info] FileSystemPersistenceEngine with KryoSerializer 179 180 2 0.0 178795.7 70.5X [info] BlackHolePersistenceEngine 0 0 0 46.6 21.5 587273.6X [success] Total time: 126 s (02:06), completed Dec 1, 2023, 7:59:25 PM ``` ### Was this patch authored or co-authored using generative AI tooling? Closes apache#44118 from dongjoon-hyun/SPARK-46205-2. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
### What changes were proposed in this pull request? This is a follow-up of apache#44113 to address a comment about simplifying the benchmark. ### Why are the changes needed? To simplify. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually. ``` $ build/sbt "core/Test/runMain org.apache.spark.deploy.master.PersistenceEngineBenchmark" ... [info] OpenJDK 64-Bit Server VM 17.0.9+9-LTS on Mac OS X 14.2 [info] Apple M1 Max [info] 1000 Workers: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative [info] ------------------------------------------------------------------------------------------------------------------------------- [info] ZooKeeperPersistenceEngine with JavaSerializer 12602 12847 253 0.0 12601717.5 1.0X [info] ZooKeeperPersistenceEngine with KryoSerializer 12116 12130 13 0.0 12116373.8 1.0X [info] FileSystemPersistenceEngine with JavaSerializer 429 435 6 0.0 429374.9 29.3X [info] FileSystemPersistenceEngine with KryoSerializer 179 180 2 0.0 178795.7 70.5X [info] BlackHolePersistenceEngine 0 0 0 46.6 21.5 587273.6X [success] Total time: 126 s (02:06), completed Dec 1, 2023, 7:59:25 PM ``` ### Was this patch authored or co-authored using generative AI tooling? Closes apache#44118 from dongjoon-hyun/SPARK-46205-2. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
### What changes were proposed in this pull request? This is a follow-up of apache#44113 to address a comment about simplifying the benchmark. ### Why are the changes needed? To simplify. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually. ``` $ build/sbt "core/Test/runMain org.apache.spark.deploy.master.PersistenceEngineBenchmark" ... [info] OpenJDK 64-Bit Server VM 17.0.9+9-LTS on Mac OS X 14.2 [info] Apple M1 Max [info] 1000 Workers: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative [info] ------------------------------------------------------------------------------------------------------------------------------- [info] ZooKeeperPersistenceEngine with JavaSerializer 12602 12847 253 0.0 12601717.5 1.0X [info] ZooKeeperPersistenceEngine with KryoSerializer 12116 12130 13 0.0 12116373.8 1.0X [info] FileSystemPersistenceEngine with JavaSerializer 429 435 6 0.0 429374.9 29.3X [info] FileSystemPersistenceEngine with KryoSerializer 179 180 2 0.0 178795.7 70.5X [info] BlackHolePersistenceEngine 0 0 0 46.6 21.5 587273.6X [success] Total time: 126 s (02:06), completed Dec 1, 2023, 7:59:25 PM ``` ### Was this patch authored or co-authored using generative AI tooling? Closes apache#44118 from dongjoon-hyun/SPARK-46205-2. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 16, 2024
### What changes were proposed in this pull request? This is a logical revert of SPARK-46205 - #44113 - #44118 ### Why are the changes needed? The initial implementation didn't handle the class initialization logic properly. Until we have a fix, I'd like to revert this from `master` branch. ### Does this PR introduce _any_ user-facing change? No, this is not released yet. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46087 from dongjoon-hyun/SPARK-47875. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #44113 to address a comment about simplifying the benchmark.
Why are the changes needed?
To simplify.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually.
Was this patch authored or co-authored using generative AI tooling?