[SPARK-47875][CORE] Remove spark.deploy.recoverySerializer
#46087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry but could you review this reverting PR, @viirya ? While I've running this, I found my mistake. |
viirya
approved these changes
Apr 16, 2024
|
Pending CI. Thanks @dongjoon-hyun |
|
Thank you so much for swift help. I'll make it sure that all CIes passes. |
viirya
reviewed
Apr 16, 2024
|
Yes, there are other commits about |
|
I removed the missed SPARK-46205 test case. |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
This is a logical revert of SPARK-46205 - apache#44113 - apache#44118 The initial implementation didn't handle the class initialization logic properly. Until we have a fix, I'd like to revert this from `master` branch. No, this is not released yet. Pass the CIs. No. Closes apache#46087 from dongjoon-hyun/SPARK-47875. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a logical revert of SPARK-46205
PersistenceEngineperformance withKryoSerializer#44113Why are the changes needed?
The initial implementation didn't handle the class initialization logic properly.
Until we have a fix, I'd like to revert this from
masterbranch.Does this PR introduce any user-facing change?
No, this is not released yet.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.