[SPARK-47922][SQL] Implement the try_parse_json expression #46141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with parse_json and variant_get
…authentication errors
…hema is variant type
…essions/jsonExpressions.scala Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com>
…park into from_json_variant
cloud-fan
reviewed
Apr 22, 2024
| // scalastyle:on line.size.limit | ||
| case class TryParseJson(expr: Expression, replacement: Expression) | ||
| extends RuntimeReplaceable with InheritAnalysisRules { | ||
| def this(child: Expression) = this(child, TryEval(ParseJson(child))) |
There was a problem hiding this comment.
I'm not a big fan of the TryEval approach, as it's more like a temporary workaround. See this TODO: https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryEval.scala#L83
The issue is, TryEval swallows all the exceptions, including the ones from inputs. e.g. try_parse_json(a function that produces JSON string but fails) should still fail.
There was a problem hiding this comment.
I understand. I have reimplemented it and made it similar to the implementation of the try_variant_get expression.
cloud-fan
approved these changes
Apr 22, 2024
…into try_parse_json
…ython_scalar_variant
|
thanks, merging to master! |
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 7, 2024
### What changes were proposed in this pull request? The `try_parse_json` expression added in #46141 declares improper output nullability: the `try_` version's output must be marked as nullable. This PR corrects the nullability and adds a test. ### Why are the changes needed? Incorrectly declaring an expression's output as non-nullable when it is actually nullable may lead to crashes. ### Does this PR introduce _any_ user-facing change? Yes, it affects output nullability and thus may affect query result schemas. ### How was this patch tested? New unit test cases. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46409 from JoshRosen/fix-try-parse-json-nullability. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? This pull request implements the `try_parse_json` that runs `parse_json` on string expressions to extract variants. However, if `parse_json` throws an exception on a row, the value `null` is returned. ### Why are the changes needed? Sometimes, columns containing JSON strings may contain some invalid inputs that should be ignored instead of having the whole execution failed because of it. ### Does this PR introduce _any_ user-facing change? Yes, it allows users to run the `try_parse_json` expression. ### How was this patch tested? Unit tests to check if `try_parse_json` works just like `parse_json` on valid inputs, returns `null` on invalid inputs, and fails on incorrect input data types. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46141 from harshmotw-db/try_parse_json. Authored-by: Harsh Motwani <harsh.motwani@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? The `try_parse_json` expression added in apache#46141 declares improper output nullability: the `try_` version's output must be marked as nullable. This PR corrects the nullability and adds a test. ### Why are the changes needed? Incorrectly declaring an expression's output as non-nullable when it is actually nullable may lead to crashes. ### Does this PR introduce _any_ user-facing change? Yes, it affects output nullability and thus may affect query result schemas. ### How was this patch tested? New unit test cases. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46409 from JoshRosen/fix-try-parse-json-nullability. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pull request implements the
try_parse_jsonthat runsparse_jsonon string expressions to extract variants. However, ifparse_jsonthrows an exception on a row, the valuenullis returned.Why are the changes needed?
Sometimes, columns containing JSON strings may contain some invalid inputs that should be ignored instead of having the whole execution failed because of it.
Does this PR introduce any user-facing change?
Yes, it allows users to run the
try_parse_jsonexpression.How was this patch tested?
Unit tests to check if
try_parse_jsonworks just likeparse_jsonon valid inputs, returnsnullon invalid inputs, and fails on incorrect input data types.Was this patch authored or co-authored using generative AI tooling?
No