[SPARK-48150][SQL] try_parse_json output should be declared as nullable #46409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @harshmotw-db and @cloud-fan from #46141 |
harshmotw-db
approved these changes
May 6, 2024
HyukjinKwon
approved these changes
May 7, 2024
dongjoon-hyun
approved these changes
May 7, 2024
|
According to the CI result, maybe |
|
It's not flaky, it's a legitimate test failure: |
|
Wow! Thank you for the fix. |
|
Merged to master for Apache Spark 4.0.0-preview. Thank you, @JoshRosen and all. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? The `try_parse_json` expression added in apache#46141 declares improper output nullability: the `try_` version's output must be marked as nullable. This PR corrects the nullability and adds a test. ### Why are the changes needed? Incorrectly declaring an expression's output as non-nullable when it is actually nullable may lead to crashes. ### Does this PR introduce _any_ user-facing change? Yes, it affects output nullability and thus may affect query result schemas. ### How was this patch tested? New unit test cases. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46409 from JoshRosen/fix-try-parse-json-nullability. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
try_parse_jsonexpression added in #46141 declares improper output nullability: thetry_version's output must be marked as nullable. This PR corrects the nullability and adds a test.Why are the changes needed?
Incorrectly declaring an expression's output as non-nullable when it is actually nullable may lead to crashes.
Does this PR introduce any user-facing change?
Yes, it affects output nullability and thus may affect query result schemas.
How was this patch tested?
New unit test cases.
Was this patch authored or co-authored using generative AI tooling?
No.