Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48116][INFRA][FOLLOWUP] Fix if statement to check repository #46379

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 4, 2024

What changes were proposed in this pull request?

This is a follow-up of the following to fix if statement.

Why are the changes needed?

Currently, master branch works like the following.

https://github.com/apache/spark/actions/runs/8947915962/job/24580432178

It was a mistake to use string evaluation type which goes to then statement as a result.

    if [ "false" ]; then
      pandas=$pyspark
    else
      pandas=false
    fi

Like the following, this PR fixes if statement.

if [[ "$MODULES_TO_TEST" == "hive" ]] && [[ "$EXCLUDED_TAGS" == "org.apache.spark.tags.SlowHiveTest" ]]; then export METASPACE_SIZE=2g; fi

The following is the new result on this PR Builder.

    if [[ "dongjoon-hyun/spark" != 'apache/spark' ]]; then
      pandas=$pyspark
    else
      pandas=false
    fi

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual review.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label May 4, 2024
@HyukjinKwon
Copy link
Member

@dongjoon-hyun Can we maybe just merge #46380 instead?

@dongjoon-hyun
Copy link
Member Author

Of course.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-48116-2 branch May 4, 2024 05:01
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I cherry-picked this instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants