[SPARK-48116][INFRA][FOLLOWUP] Simplify the build with fixing the if condition #46380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Daily Python CIs" This reverts commit 1904dee.
dongjoon-hyun
approved these changes
May 4, 2024
|
Feel free to merge at any time when this PR is ready ~ |
dongjoon-hyun
changed the title
|
Merged to master. |
|
Reverted. I will make a new try with trying within my own fork. I cherry-picked yours and merged it. |
|
Oh, thank you for the fast recovery. Looking forward to seeing the new try. |
HyukjinKwon
added a commit
that referenced
this pull request
May 4, 2024
…ogic ### What changes were proposed in this pull request? This PR is another try of #46380 that is a followup of #46367 that simplifies the build and deduplicate them. ### Why are the changes needed? To fix the condition, and make it deduplicated. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Will test in my own fork: https://github.com/HyukjinKwon/spark/actions/runs/8948215777 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46381 from HyukjinKwon/SPARK-48116-followup2. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sinaiamonkar-sai
pushed a commit
to sinaiamonkar-sai/spark
that referenced
this pull request
May 5, 2024
…condition ### What changes were proposed in this pull request? This PR is a followup of apache#46367 that simplifies the build and deduplicate them. ### Why are the changes needed? To fix the condition, and make it deduplicated. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46380 from HyukjinKwon/SPARK-48116-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sinaiamonkar-sai
pushed a commit
to sinaiamonkar-sai/spark
that referenced
this pull request
May 5, 2024
…ogic ### What changes were proposed in this pull request? This PR is another try of apache#46380 that is a followup of apache#46367 that simplifies the build and deduplicate them. ### Why are the changes needed? To fix the condition, and make it deduplicated. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Will test in my own fork: https://github.com/HyukjinKwon/spark/actions/runs/8948215777 ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46381 from HyukjinKwon/SPARK-48116-followup2. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…condition ### What changes were proposed in this pull request? This PR is a followup of apache#46367 that simplifies the build and deduplicate them. ### Why are the changes needed? To fix the condition, and make it deduplicated. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46380 from HyukjinKwon/SPARK-48116-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…ogic ### What changes were proposed in this pull request? This PR is another try of apache#46380 that is a followup of apache#46367 that simplifies the build and deduplicate them. ### Why are the changes needed? To fix the condition, and make it deduplicated. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Will test in my own fork: https://github.com/HyukjinKwon/spark/actions/runs/8948215777 ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46381 from HyukjinKwon/SPARK-48116-followup2. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #46367 that simplifies the build and deduplicate them.
Why are the changes needed?
To fix the condition, and make it deduplicated.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Manually.
Was this patch authored or co-authored using generative AI tooling?
No.