Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6113] [ml] Small cleanups after original tree API PR #5567

Closed
wants to merge 2 commits into from
Closed

[SPARK-6113] [ml] Small cleanups after original tree API PR #5567

wants to merge 2 commits into from

Conversation

jkbradley
Copy link
Member

This does a few clean-ups. With this PR, all spark.ml tree components have private[ml] constructors.

CC: @mengxr

@SparkQA
Copy link

SparkQA commented Apr 18, 2015

Test build #30505 timed out for PR 5567 at commit bb9f610 after a configured wait of 150m.

@SparkQA
Copy link

SparkQA commented Apr 18, 2015

Test build #689 has started for PR 5567 at commit bb9f610.

@jkbradley
Copy link
Member Author

Jenkins didn't post it here, but it looks like the tests passed.

@SparkQA
Copy link

SparkQA commented Apr 20, 2015

Test build #690 has finished for PR 5567 at commit bb9f610.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@jkbradley jkbradley mentioned this pull request Apr 21, 2015
Closed
@SparkQA
Copy link

SparkQA commented Apr 21, 2015

Test build #30684 has finished for PR 5567 at commit 2263b5b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@mengxr
Copy link
Contributor

mengxr commented Apr 22, 2015

LGTM. Merged into master. Thanks!

@asfgit asfgit closed this in 607eff0 Apr 22, 2015
@jkbradley jkbradley deleted the dt-api-dt2 branch May 4, 2015 23:02
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@jkbradley @nemccarthy
[SPARK-6113] [ML] Small cleanups after original tree API PR
574cdd4 
This does a few clean-ups.  With this PR, all spark.ml tree components have ```private[ml]``` constructors.

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes apache#5567 from jkbradley/dt-api-dt2 and squashes the following commits:

2263b5b [Joseph K. Bradley] Added note about tree example issue.
bb9f610 [Joseph K. Bradley] Small cleanups after original tree API PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkbradley @SparkQA @mengxr