Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6940][MLLIB] Add CrossValidator to Python ML pipeline API #5926

Closed
wants to merge 5 commits into from
Closed

[SPARK-6940][MLLIB] Add CrossValidator to Python ML pipeline API #5926

wants to merge 5 commits into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented May 5, 2015

Since CrossValidator is a meta algorithm, we copy the implementation in Python. @jkbradley

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31918 has finished for PR 5926 at commit 060f7c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Model(Transformer):
    • class CrossValidator(Estimator):
    • class CrossValidatorModel(Model):
    • class JavaModel(Model, JavaTransformer):

jkbradley
jkbradley reviewed May 6, 2015
View reviewed changes
python/pyspark/ml/pipeline.py
@@ -71,6 +71,15 @@ def transform(self, dataset, params={}):


@inherit_doc
class Model(Transformer):
"""
Abstract class for models that fitted by estimators.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that fitted" --> "that are fitted"

@jkbradley
Copy link
Member

@mengxr LGTM other than the small comments above

@jkbradley
Copy link
Member

LGTM

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31955 has finished for PR 5926 at commit 6af181f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Model(Transformer):
    • class PipelineModel(Model):
    • class CrossValidator(Estimator):
    • class CrossValidatorModel(Model):
    • class JavaModel(Model, JavaTransformer):

@mengxr
Copy link
Contributor Author

mengxr commented May 6, 2015

Merged into master and branch-1.4.

asfgit pushed a commit that referenced this pull request May 6, 2015
@mengxr
[SPARK-6940] [MLLIB] Add CrossValidator to Python ML pipeline API
3e27a54 
Since CrossValidator is a meta algorithm, we copy the implementation in Python. jkbradley

Author: Xiangrui Meng <meng@databricks.com>

Closes #5926 from mengxr/SPARK-6940 and squashes the following commits:

6af181f [Xiangrui Meng] add TODOs
8285134 [Xiangrui Meng] update doc
060f7c3 [Xiangrui Meng] update doctest
acac727 [Xiangrui Meng] add keyword args
cdddecd [Xiangrui Meng] add CrossValidator in Python

(cherry picked from commit 32cdc81)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 32cdc81 May 6, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@mengxr @jeanlyn
[SPARK-6940] [MLLIB] Add CrossValidator to Python ML pipeline API
b4e3b1e 
Since CrossValidator is a meta algorithm, we copy the implementation in Python. jkbradley

Author: Xiangrui Meng <meng@databricks.com>

Closes apache#5926 from mengxr/SPARK-6940 and squashes the following commits:

6af181f [Xiangrui Meng] add TODOs
8285134 [Xiangrui Meng] update doc
060f7c3 [Xiangrui Meng] update doctest
acac727 [Xiangrui Meng] add keyword args
cdddecd [Xiangrui Meng] add CrossValidator in Python
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@mengxr @jeanlyn
[SPARK-6940] [MLLIB] Add CrossValidator to Python ML pipeline API
4197f74 
Since CrossValidator is a meta algorithm, we copy the implementation in Python. jkbradley

Author: Xiangrui Meng <meng@databricks.com>

Closes apache#5926 from mengxr/SPARK-6940 and squashes the following commits:

6af181f [Xiangrui Meng] add TODOs
8285134 [Xiangrui Meng] update doc
060f7c3 [Xiangrui Meng] update doctest
acac727 [Xiangrui Meng] add keyword args
cdddecd [Xiangrui Meng] add CrossValidator in Python
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@mengxr @nemccarthy
[SPARK-6940] [MLLIB] Add CrossValidator to Python ML pipeline API
f4be7c6 
Since CrossValidator is a meta algorithm, we copy the implementation in Python. jkbradley

Author: Xiangrui Meng <meng@databricks.com>

Closes apache#5926 from mengxr/SPARK-6940 and squashes the following commits:

6af181f [Xiangrui Meng] add TODOs
8285134 [Xiangrui Meng] update doc
060f7c3 [Xiangrui Meng] update doctest
acac727 [Xiangrui Meng] add keyword args
cdddecd [Xiangrui Meng] add CrossValidator in Python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengxr @SparkQA @jkbradley