Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-7150] add range() api #6233

Closed
wants to merge 11 commits into from
Closed

[SPARK-7150] add range() api #6233

wants to merge 11 commits into from

Conversation

adrian-wang
Copy link
Contributor

This PR is based on #6230 , thanks @davies .

Closes #6230

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #32990 has started for PR 6233 at commit 59a15c5.

@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #32990 has finished for PR 6233 at commit 59a15c5.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32990/
Test FAILed.

@adrian-wang adrian-wang changed the title add range() api [SPARK-7150] add range() api May 18, 2015
@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #32991 has started for PR 6233 at commit fbb063c.

@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #32991 timed out for PR 6233 at commit fbb063c after a configured wait of 150m.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32991/
Test FAILed.

@adrian-wang
Copy link
Contributor Author

retest this please.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #32995 has started for PR 6233 at commit fbb063c.

@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #32995 has finished for PR 6233 at commit fbb063c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32995/
Test PASSed.

@adrian-wang
Copy link
Contributor Author

cc @rxin @davies

@rxin
Copy link
Contributor

rxin commented May 18, 2015

(Note that even if we merged @davies' PR, it would still show up as yours because the merge script is smart)

@adrian-wang
Copy link
Contributor Author

but there are bugs there....

@davies
Copy link
Contributor

davies commented May 18, 2015

@adrian-wang Could you say a few words about what the bug is?

davies
davies reviewed May 18, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/api/python/PythonUtils.scala
/**
* Convert java Integer into Scala Long (for calling API with varargs)
*/
def toScalaLong(ji: java.lang.Integer): Long = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not necessary, Py4j could do this automatically.

@adrian-wang
Copy link
Contributor Author

I was wrong, the type thing is not a bug. I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adrian-wang @AmplabJenkins @SparkQA @rxin @davies