Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spark-7780][MLLIB] Intercept in logisticregressionwith lbfgs should not be regularized #6386

Closed
wants to merge 24 commits into from
Closed

[Spark-7780][MLLIB] Intercept in logisticregressionwith lbfgs should not be regularized #6386

wants to merge 24 commits into from

Commits on May 24, 2015

  1. document plans

    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    a529c01 View commit details
    Browse the repository at this point in the history

  2. Some progress.

    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    f9e2635 View commit details
    Browse the repository at this point in the history

  3. Keep track of the number of requested classes so that if its more tha… 

    …n 2 we use the legacy implementation. Also allow pass through of initialWeights
    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    7ebbd56 View commit details
    Browse the repository at this point in the history

  4. Expose a train on instances method within Spark, use numOfLinearPredi… 

    …ctors instead of keeping track of class variable, pass through persistence information
    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    ef2a9b0 View commit details
    Browse the repository at this point in the history

  5. tests are fun

    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    407491e View commit details
    Browse the repository at this point in the history

  6. Start updating the tests to run with different updaters.

    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    e02bf3a View commit details
    Browse the repository at this point in the history

  7. get the tests compiling

    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    8517539 View commit details
    Browse the repository at this point in the history

  8. style fixed

    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    a619d42 View commit details
    Browse the repository at this point in the history

  9. make the test method private

    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    4febcc3 View commit details
    Browse the repository at this point in the history

  10. CR feedback, pass RDD of Labeled points to ml implemetnation. Also fr… 

    …om tests require that feature scaling is turned on to use ml implementation.
    @holdenk
    holdenk committed May 24, 2015
    Configuration menu
    Copy the full SHA
    e8e03a1 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2015

  1. Convert it to a df and use set for the inital params

    @holdenk
    holdenk committed May 25, 2015
    Configuration menu
    Copy the full SHA
    38a024b View commit details
    Browse the repository at this point in the history

  2. Handle non-dense weights

    @holdenk
    holdenk committed May 25, 2015
    Configuration menu
    Copy the full SHA
    478b8c5 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2015

  1. CR feedback: make the setInitialWeights function private, don't mess … 

    …with the weights when they are user supploed, validate that the user supplied weights are reasonable.
    @holdenk
    holdenk committed May 26, 2015
    Configuration menu
    Copy the full SHA
    08589f5 View commit details
    Browse the repository at this point in the history

  2. style fix up

    @holdenk
    holdenk committed May 26, 2015
    Configuration menu
    Copy the full SHA
    f40c401 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2015

  1. Copy the number of iterations, convergence tolerance, and if we are f… 

    …itting an intercept from mllib to ml when training lbfgs model using ml code
    @holdenk
    holdenk committed Jun 2, 2015
    Configuration menu
    Copy the full SHA
    f35a16a View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2015

  1. scala style check issue

    @holdenk
    holdenk committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    4d431a3 View commit details
    Browse the repository at this point in the history

  2. Only the weights if we need to.

    @holdenk
    holdenk committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    7e41928 View commit details
    Browse the repository at this point in the history

  3. Use appendBias for adding intercept to initial weights , fix generate… 

    …InitialWeights
    @holdenk
    holdenk committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    ed351ff View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2015

  1. Merge in master

    @holdenk
    holdenk committed Jun 8, 2015
    Configuration menu
    Copy the full SHA
    3ac02d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2015

  1. Merge in master

    @holdenk
    holdenk committed Jul 9, 2015
    Configuration menu
    Copy the full SHA
    d1ce12b View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2015

  1. attempt to merge in master

    @holdenk
    holdenk committed Aug 28, 2015
    Configuration menu
    Copy the full SHA
    8ca0fa9 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2015

  1. Merge in master (again)

    @holdenk
    holdenk committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    6f66f2c View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2015

  1. Fix compile error after simple merge

    @holdenk
    holdenk committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    0cedd50 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2015

  1. Merge branch 'master' into SPARK-7780-intercept-in-logisticregression… 

    …withLBFGS-should-not-be-regularized
    @holdenk
    holdenk committed Dec 30, 2015
    Configuration menu
    Copy the full SHA
    2bf289b View commit details
    Browse the repository at this point in the history