Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-8218][SQL] Binary log math function update. #6871

Closed
wants to merge 3 commits into from
Closed

[SPARK-8218][SQL] Binary log math function update. #6871

wants to merge 3 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Jun 18, 2015

Some minor updates based on after merging #6725.

@rxin
[SPARK-8218][SQL] Binary log math function update.
a7c1522 
Some minor updates based on after merging apache#6725.
@rxin
Copy link
Contributor Author

rxin commented Jun 18, 2015

cc @davies for review.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35097 has finished for PR 6871 at commit a7c1522.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(VectorTransformer):
    • class MatrixUDT(UserDefinedType):
    • case class UnaryPositive(child: Expression) extends UnaryArithmetic
    • case class Logarithm(left: Expression, right: Expression)
    • case class SetCommand(kv: Option[(String, Option[String])]) extends RunnableCommand with Logging
    • // Add jar to isolated hive (metadataHive) class loader.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35155 has finished for PR 6871 at commit ab51542.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Jun 18, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jun 19, 2015

Test build #35175 has finished for PR 6871 at commit ab51542.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

yjshen
yjshen reviewed Jun 19, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala

/**
* Natural log, i.e. using e as the base.
*/
def this(child: Expression) = {
this(EulerNumber(), child)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to remove this single parameter constructor, because this would make both ln and log(c) express the same thing in a SQL expression.

And also complex the binary log here to check its first argument branch in both eval & genCode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good idea. Can you fix it in your pr? I'm gonig to merge this one first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, already fix this in my pr. :)

@rxin
Copy link
Contributor Author

rxin commented Jun 19, 2015

I like that idea.

@rxin rxin closed this Jun 19, 2015
asfgit pushed a commit that referenced this pull request Jun 19, 2015
@rxin
[SPARK-8218][SQL] Binary log math function update.
dc41313 
Some minor updates based on after merging #6725.

Author: Reynold Xin <rxin@databricks.com>

Closes #6871 from rxin/log and squashes the following commits:

ab51542 [Reynold Xin] Use JVM log
76fc8de [Reynold Xin] Fixed arg.
a7c1522 [Reynold Xin] [SPARK-8218][SQL] Binary log math function update.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@rxin @nemccarthy
[SPARK-8218][SQL] Binary log math function update.
8d4bcd2 
Some minor updates based on after merging apache#6725.

Author: Reynold Xin <rxin@databricks.com>

Closes apache#6871 from rxin/log and squashes the following commits:

ab51542 [Reynold Xin] Use JVM log
76fc8de [Reynold Xin] Fixed arg.
a7c1522 [Reynold Xin] [SPARK-8218][SQL] Binary log math function update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rxin @SparkQA @yjshen