Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-8451][SPARK-7287] SparkSubmitSuite should check exit code #6886

Closed
wants to merge 3 commits into from
Closed

[SPARK-8451][SPARK-7287] SparkSubmitSuite should check exit code #6886

wants to merge 3 commits into from

Conversation

andrewor14
Copy link
Contributor

This patch also reenables the tests. Now that we have access to the log4j logs it should be easier to debug the flakiness.

@yhuai @brkyvz

@yhuai
Copy link
Contributor

yhuai commented Jun 18, 2015

lgtm

@andrewor14
Copy link
Contributor Author

Ok, I have triggered a bunch of builds for this patch to test the flakiness. We'll see how things go.

@andrewor14 andrewor14 mentioned this pull request Jun 18, 2015
Closed
@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #921 has finished for PR 6886 at commit 9a62188.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(VectorTransformer):
    • class MatrixUDT(UserDefinedType):
    • case class UnaryPositive(child: Expression) extends UnaryArithmetic
    • case class CreateStruct(children: Seq[Expression]) extends Expression
    • case class Sqrt(child: Expression) extends UnaryMathExpression(math.sqrt, "SQRT")
    • case class Logarithm(left: Expression, right: Expression)
    • case class IsNull(child: Expression) extends UnaryExpression with Predicate
    • case class IsNotNull(child: Expression) extends UnaryExpression with Predicate
    • case class SetCommand(kv: Option[(String, Option[String])]) extends RunnableCommand with Logging
    • // Add jar to isolated hive (metadataHive) class loader.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #926 has finished for PR 6886 at commit 9a62188.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #923 has finished for PR 6886 at commit 9a62188.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #928 has finished for PR 6886 at commit 3f99ff1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(VectorTransformer):
    • class MatrixUDT(UserDefinedType):
    • case class UnaryPositive(child: Expression) extends UnaryArithmetic
    • case class CreateStruct(children: Seq[Expression]) extends Expression
    • case class Sqrt(child: Expression) extends UnaryMathExpression(math.sqrt, "SQRT")
    • case class Logarithm(left: Expression, right: Expression)
    • case class IsNull(child: Expression) extends UnaryExpression with Predicate
    • case class IsNotNull(child: Expression) extends UnaryExpression with Predicate
    • case class SetCommand(kv: Option[(String, Option[String])]) extends RunnableCommand with Logging
    • // Add jar to isolated hive (metadataHive) class loader.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #922 has finished for PR 6886 at commit 9a62188.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ElementwiseProduct(VectorTransformer):
    • class MatrixUDT(UserDefinedType):
    • case class UnaryPositive(child: Expression) extends UnaryArithmetic
    • case class CreateStruct(children: Seq[Expression]) extends Expression
    • case class Sqrt(child: Expression) extends UnaryMathExpression(math.sqrt, "SQRT")
    • case class Logarithm(left: Expression, right: Expression)
    • case class SetCommand(kv: Option[(String, Option[String])]) extends RunnableCommand with Logging
    • // Add jar to isolated hive (metadataHive) class loader.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35160 has finished for PR 6886 at commit 3f99ff1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Sqrt(child: Expression) extends UnaryMathExpression(math.sqrt, "SQRT")

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #927 has finished for PR 6886 at commit 3f99ff1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35158 has finished for PR 6886 at commit 9a62188.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Sqrt(child: Expression) extends UnaryMathExpression(math.sqrt, "SQRT")

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #924 has finished for PR 6886 at commit 9a62188.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #920 has finished for PR 6886 at commit 9a62188.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #919 timed out for PR 6886 at commit 9a62188 after a configured wait of 175m.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #925 timed out for PR 6886 at commit 9a62188 after a configured wait of 175m.

@SparkQA
Copy link

SparkQA commented Jun 19, 2015

Test build #934 has finished for PR 6886 at commit 3f99ff1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

retest this please

@andrewor14
Copy link
Contributor Author

None of the failed tests are SparkSubmitSuite. I'm going to merge this into master. If the tests fail we can reenable them again...

asfgit pushed a commit that referenced this pull request Jun 19, 2015
[SPARK-8451] [SPARK-7287] SparkSubmitSuite should check exit code
aedd893 
This patch also reenables the tests. Now that we have access to the log4j logs it should be easier to debug the flakiness.

yhuai brkyvz

Author: Andrew Or <andrew@databricks.com>

Closes #6886 from andrewor14/spark-submit-suite-fix and squashes the following commits:

3f99ff1 [Andrew Or] Move destroy to finally block
9a62188 [Andrew Or] Re-enable ignored tests
2382672 [Andrew Or] Check for exit code

(cherry picked from commit 68a2dca)
Signed-off-by: Andrew Or <andrew@databricks.com>
asfgit pushed a commit that referenced this pull request Jun 19, 2015
[SPARK-8451] [SPARK-7287] SparkSubmitSuite should check exit code
1d44147 
This patch also reenables the tests. Now that we have access to the log4j logs it should be easier to debug the flakiness.

yhuai brkyvz

Author: Andrew Or <andrew@databricks.com>

Closes #6886 from andrewor14/spark-submit-suite-fix and squashes the following commits:

3f99ff1 [Andrew Or] Move destroy to finally block
9a62188 [Andrew Or] Re-enable ignored tests
2382672 [Andrew Or] Check for exit code

(cherry picked from commit 68a2dca)
Signed-off-by: Andrew Or <andrew@databricks.com>

Conflicts:
	core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
@asfgit asfgit closed this in 68a2dca Jun 19, 2015
@andrewor14 andrewor14 deleted the spark-submit-suite-fix branch June 19, 2015 17:58
@SparkQA
Copy link

SparkQA commented Jun 19, 2015

Test build #35295 has finished for PR 6886 at commit 3f99ff1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 22, 2015
@nemccarthy
[SPARK-8451] [SPARK-7287] SparkSubmitSuite should check exit code
83fa743 
This patch also reenables the tests. Now that we have access to the log4j logs it should be easier to debug the flakiness.

yhuai brkyvz

Author: Andrew Or <andrew@databricks.com>

Closes apache#6886 from andrewor14/spark-submit-suite-fix and squashes the following commits:

3f99ff1 [Andrew Or] Move destroy to finally block
9a62188 [Andrew Or] Re-enable ignored tests
2382672 [Andrew Or] Check for exit code

(cherry picked from commit 68a2dca)
Signed-off-by: Andrew Or <andrew@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewor14 @yhuai @SparkQA