Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-8902] Correctly print hostname in error #7288

Closed
wants to merge 1 commit into from
Closed

[SPARK-8902] Correctly print hostname in error #7288

wants to merge 1 commit into from

Conversation

darabos
Copy link
Contributor

@darabos darabos commented Jul 8, 2015

With "+" the strings are separate expressions, and format() is called on the last string before concatenation. (So substitution does not happen.) Without "+" the string literals are merged first by the parser, so format() is called on the complete string.

Should I make a JIRA for this?

@darabos
Correctly print hostname in error
be0d3b7 
With "+" the strings are separate expressions, and format() is called on the last string before concatenation. (So substitution does not happen.) Without "+" the string literals are merged first by the parser, so format() is called on the complete string.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Jul 8, 2015

OK to test

@srowen
Copy link
Member

srowen commented Jul 8, 2015

(Thought I don't think jenkins tests this.) LGTM

@SparkQA
Copy link

SparkQA commented Jul 8, 2015

Test build #1015 has started for PR 7288 at commit be0d3b7.

@SparkQA
Copy link

SparkQA commented Jul 8, 2015

Test build #1015 has finished for PR 7288 at commit be0d3b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

@darabos it would be good to file a trivial JIRA, and explain briefly how the output differs before and after this change. In general we should try to track all patches even for small ones like these, but this particular patch is really border line I think.

@darabos darabos changed the title Correctly print hostname in error [SPARK-8902] Correctly print hostname in error Jul 8, 2015
@darabos
Copy link
Contributor Author

darabos commented Jul 8, 2015

@darabos it would be good to file a trivial JIRA, and explain briefly how the output differs before and after this change. In general we should try to track all patches even for small ones like these, but this particular patch is really border line I think.

Sure. A JIRA doesn't cost anything. I've filed https://issues.apache.org/jira/browse/SPARK-8902.

@sarutak
Copy link
Member

sarutak commented Jul 8, 2015

ok to test.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 8, 2015

Test build #36845 has started for PR 7288 at commit be0d3b7.

@SparkQA
Copy link

SparkQA commented Jul 8, 2015

Test build #36845 has finished for PR 7288 at commit be0d3b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@sarutak
Copy link
Member

sarutak commented Jul 8, 2015

Thanks @darabos , merging into master and branch-1.4.

asfgit pushed a commit that referenced this pull request Jul 8, 2015
@darabos @sarutak
[SPARK-8902] Correctly print hostname in error
df76349 
With "+" the strings are separate expressions, and format() is called on the last string before concatenation. (So substitution does not happen.) Without "+" the string literals are merged first by the parser, so format() is called on the complete string.

Should I make a JIRA for this?

Author: Daniel Darabos <darabos.daniel@gmail.com>

Closes #7288 from darabos/patch-2 and squashes the following commits:

be0d3b7 [Daniel Darabos] Correctly print hostname in error

(cherry picked from commit 5687f76)
Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
@asfgit asfgit closed this in 5687f76 Jul 8, 2015
@rxin
Copy link
Contributor

rxin commented Jul 8, 2015

Does this actually work? @marmbrus tried it in the repl and couldn't get it working.

@rxin
Copy link
Contributor

rxin commented Jul 8, 2015

Ah never mind this is python. Ignore me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darabos @AmplabJenkins @srowen @SparkQA @andrewor14 @sarutak @rxin