New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-5423][Core]Register a TaskCompletionListener to make sure release all resources #7529

Closed

zsxwing wants to merge 3 commits into apache:master from zsxwing:SPARK-5423

Member

zsxwing commented Jul 20, 2015

Make DiskMapIterator.cleanup idempotent and register a TaskCompletionListener to make sure call cleanup.


          Register a TaskCompletionListener to make sure release all resources

3d574d9

SparkQA commented Jul 20, 2015

Test build #37820 has finished for PR 7529 at commit 3d574d9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.


          Fix NullPointerException for tests

9556c78

Contributor

squito commented Jul 20, 2015

think we can delete the TODO on cleanup now? looks like your change should take care of it.

changes lgtm

SparkQA commented Jul 20, 2015

Test build #37840 has finished for PR 7529 at commit 9556c78.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.


          Remove TODO

3e3c413

Member Author

zsxwing commented Jul 20, 2015

think we can delete the TODO on cleanup now? looks like your change should take care of it.

Right. Removed it.

SparkQA commented Jul 21, 2015

Test build #37866 has finished for PR 7529 at commit 3e3c413.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Contributor

andrewor14 commented Jul 21, 2015

LGTM merging into master

asfgit closed this in

d45355e

zsxwing deleted the SPARK-5423 branch

July 21, 2015 16:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment