-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-9154][SQL] codegen StringFormat #7571
Conversation
@@ -486,6 +486,10 @@ case class StringFormat(children: Expression*) extends Expression with CodegenFa | |||
private def format: Expression = children(0) | |||
private def args: Seq[Expression] = children.tail | |||
|
|||
override def inputTypes: Seq[AbstractDataType] = | |||
StringType :: List.fill(children.size - 1)(AnyDataType) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this as well.
ok to test |
It was my mistake -- I shouldn't have taken out the formatString with Columns, except the 1st argument should be a String. |
Should I add it again? |
Yes please. |
@rxin Could you trigger Jenkins |
ok to test |
Test build #37983 has finished for PR 7571 at commit
|
Jenkins, retest this please. |
* @since 1.5.0 | ||
*/ | ||
@scala.annotation.varargs | ||
def formatString(format: Column, arguments: Column*): Column = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was thinking about a a version in which format is a string, but rest of the arguments are columns.
Test build #1150 has finished for PR 7571 at commit
|
Jira: https://issues.apache.org/jira/browse/SPARK-9154
fixes bug of #7546
@marmbrus I can't reopen the other PR, because I didn't closed it. Can you trigger Jenkins?