[SPARK-9154][SQL] codegen StringFormat #7571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -486,6 +486,10 @@ case class StringFormat(children: Expression*) extends Expression with CodegenFa | |||
| private def format: Expression = children(0) | |||
| private def args: Seq[Expression] = children.tail | |||
|
|
|||
| override def inputTypes: Seq[AbstractDataType] = | |||
| StringType :: List.fill(children.size - 1)(AnyDataType) | |||
There was a problem hiding this comment.
I updated this as well.
|
ok to test |
|
It was my mistake -- I shouldn't have taken out the formatString with Columns, except the 1st argument should be a String. |
|
Should I add it again? |
|
Yes please. |
|
@rxin Could you trigger Jenkins |
|
ok to test |
|
Test build #37983 has finished for PR 7571 at commit
|
|
Jenkins, retest this please. |
| * @since 1.5.0 | ||
| */ | ||
| @scala.annotation.varargs | ||
| def formatString(format: Column, arguments: Column*): Column = { |
There was a problem hiding this comment.
i was thinking about a a version in which format is a string, but rest of the arguments are columns.
|
Test build #1150 has finished for PR 7571 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/SPARK-9154
fixes bug of #7546
@marmbrus I can't reopen the other PR, because I didn't closed it. Can you trigger Jenkins?