Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-9254] [BUILD] [HOTFIX] sbt-launch-lib.bash should support HTTP/HTTPS redirection #7597

Closed
wants to merge 2 commits into from

Conversation

liancheng
Copy link
Contributor

Target file(s) can be hosted on CDN nodes. HTTP/HTTPS redirection must be supported to download these files.

@liancheng liancheng changed the title [SPARK-9254] [BUILD] sbt-launch-lib.bash should support HTTP/HTTPS redirection [SPARK-9254] [BUILD] [HOTFIX] sbt-launch-lib.bash should support HTTP/HTTPS redirection Jul 22, 2015
@liancheng
Copy link
Contributor Author

Jenkins PR builders are down. Because the 1st candidate URL for sbt-launch.lib is down, while the 2nd redirects requests to CDN and gives 302.

@SparkQA
Copy link

SparkQA commented Jul 22, 2015

Test build #38082 has finished for PR 7597 at commit a7cbfb3.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor

yhuai commented Jul 22, 2015

LGTM. Thanks for the fix. I am merging it to master. If everything is good, I will merge it to 1.4 branch as well.

@asfgit asfgit closed this in b55a36b Jul 22, 2015
@liancheng liancheng deleted the spark-9254 branch July 22, 2015 16:41
@SparkQA
Copy link

SparkQA commented Jul 22, 2015

Test build #38085 has finished for PR 7597 at commit fd266ca.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jul 25, 2015
…/HTTPS redirection

Target file(s) can be hosted on CDN nodes. HTTP/HTTPS redirection must be supported to download these files.

Author: Cheng Lian <lian@databricks.com>

Closes #7597 from liancheng/spark-9254 and squashes the following commits:

fd266ca [Cheng Lian] Uses `--fail' to make curl return non-zero value and remove garbage output when the download fails
a7cbfb3 [Cheng Lian] Supports HTTP/HTTPS redirection

(cherry picked from commit b55a36b)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@yhuai
Copy link
Contributor

yhuai commented Jul 25, 2015

I have merged this to branch 1.4.

@srowen
Copy link
Member

srowen commented Aug 2, 2015

I am going to back-port to branch-1.3 as I think those builds are failing for a similar reason: https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1279/consoleFull

asfgit pushed a commit that referenced this pull request Aug 2, 2015
…/HTTPS redirection

Target file(s) can be hosted on CDN nodes. HTTP/HTTPS redirection must be supported to download these files.

Author: Cheng Lian <lian@databricks.com>

Closes #7597 from liancheng/spark-9254 and squashes the following commits:

fd266ca [Cheng Lian] Uses `--fail' to make curl return non-zero value and remove garbage output when the download fails
a7cbfb3 [Cheng Lian] Supports HTTP/HTTPS redirection

(cherry picked from commit b55a36b)
Signed-off-by: Sean Owen <sowen@cloudera.com>
kayousterhout pushed a commit to kayousterhout/spark-1 that referenced this pull request Aug 27, 2015
…/HTTPS redirection

Target file(s) can be hosted on CDN nodes. HTTP/HTTPS redirection must be supported to download these files.

Author: Cheng Lian <lian@databricks.com>

Closes apache#7597 from liancheng/spark-9254 and squashes the following commits:

fd266ca [Cheng Lian] Uses `--fail' to make curl return non-zero value and remove garbage output when the download fails
a7cbfb3 [Cheng Lian] Supports HTTP/HTTPS redirection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants