[SPARK-9262][build] Treat Scala compiler warnings as errors #7598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxin
changed the title
| @@ -94,6 +94,8 @@ private[spark] object JsonProtocol { | |||
| logStartToJson(logStart) | |||
| case metricsUpdate: SparkListenerExecutorMetricsUpdate => | |||
| executorMetricsUpdateToJson(metricsUpdate) | |||
| case blockUpdated: SparkListenerBlockUpdated => | |||
| throw new MatchError(blockUpdated) // TODO(ekl) implement this | |||
There was a problem hiding this comment.
I think there's an open PR to implement this.
|
Test build #38106 has finished for PR 7598 at commit
|
|
I wonder if we'll see any 2.11 compile breaks due to this in case 2.11 adds new warnings. |
|
I think there are generally no un-resolvable Scala warnings in Spark, and I do find it's been necessary several times to go back and squash lots of warning-generating code that's been committed. Some Scala warnings in 2.10 are errors in 2.11, even. So, yeah I'd prefer to enforce this more strictly too. |
|
Test build #38109 has finished for PR 7598 at commit
|
|
Test build #38128 has finished for PR 7598 at commit
|
|
Alright I'm going to merge this. |
|
👍 |
|
Well after the fact, sorry, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a few cases in the past few weeks that the compiler is throwing warnings that are caused by legitimate bugs. This patch upgrades warnings to errors, except deprecation warnings.
Note that ideally we should be able to mark deprecation warnings as errors as well. However, due to the lack of ability to suppress individual warning messages in the Scala compiler, we cannot do that (since we do need to access deprecated APIs in Hadoop).
Most of the work are done by @ericl.