[SPARK-9877][Core] Fix StandaloneRestServer NPE when submitting application

[jerryshao]

Detailed exception log can be seen in SPARK-9877, the problem is when creating StandaloneRestServer, self (masterEndpoint) is null. So this fix is creating StandaloneRestServer when self is available.

[SparkQA]

Test build #40630 timed out for PR 8127 at commit fdb6158 after a configured wait of 175m.

[andrewor14]

retest this please

[andrewor14]

@jerryshao weird, I've been running this and it works for me. How did you reproduce it?

[jerryshao]

@andrewor14 , I just started a local pseudo standalone cluster in my machine with master and worker in one machine, and then submitted a simple SparkPi application and then meet such exception as SPARK-9877 mentioned.

Here is the command line.

./bin/spark-submit --verbose --master spark://hw12100.local:6066 --deploy-mode cluster --class org.apache.spark.examples.SparkPi examples/target/scala-2.10/spark-examples-1.5.0-SNAPSHOT-hadoop2.6.0.jar

[jerryshao]

I dumped the value of self when rest sever is created for debugging, it is null, seems the variable is not yet initialized.

[andrewor14]

How did you set up your cluster? It works when I do the following:

# conf/slaves
localhost

$ sbin/stop-all.sh
$ sbin/start-all.sh
$ bin/spark-submit --master spark://...:6066 ...

[jerryshao]

Hi @andrewor14 , yes, I testes with same way. Did you test with latest master? I tested using 1.4.1 release, seems no such exception.

[andrewor14]

Ah, I just reproduced it! Do you know what caused this?

[andrewor14]

Looks like that line was added in #5392

[jerryshao]

I've already mentioned before, self (masterEndpoint) is null when creating StandaloneRestServer, so using this to submit application will meet NPE, need to delay the creation when self is initialized.

[jerryshao]

Yeah, I think the new RPC framework may break the old code.

[andrewor14]

I've bumped up the priority on this since this is a regression. LGTM will merge once tests pass. retest this please

[SparkQA]

Test build #40721 has finished for PR 8127 at commit fdb6158.

• This patch fails PySpark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[jerryshao]

Jenkins, retest this please.

[SparkQA]

Test build #40744 has finished for PR 8127 at commit fdb6158.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[andrewor14]

retest this please. I just fixed a potential source of flakiness

[SparkQA]

Test build #40790 has finished for PR 8127 at commit fdb6158.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[andrewor14]

retest test test test this please

[jerryshao]

The unit test seems so flaky :)

[SparkQA]

Test build #1578 has finished for PR 8127 at commit fdb6158.

• This patch fails SparkR unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #1577 has finished for PR 8127 at commit fdb6158.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #1576 timed out for PR 8127 at commit fdb6158 after a configured wait of 175m.

[SparkQA]

Test build #40824 timed out for PR 8127 at commit fdb6158 after a configured wait of 175m.

[jerryshao]

Jenkins, retest this please.

[SparkQA]

Test build #40860 has finished for PR 8127 at commit fdb6158.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[andrewor14]

Great, merging into master 1.5. Thanks @jerryshao for catching this!