[SPARK-10178][SQL] HiveComparisionTest should print out dependent tables #8388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @JoshRosen |
|
Test build #41440 has finished for PR 8388 at commit
|
| TestHive.reset() | ||
| val executions = queryList.map(new TestHive.QueryExecution(_)) | ||
| executions.foreach(_.toRdd) | ||
| val tablesGenerated = queryList.zip(executions).flatMap{ |
|
LGTM overall, modulo a few minor nits. |
|
Test build #41503 has finished for PR 8388 at commit
|
|
I've merged this into master & branch-1.5 (since it is test only). |
asfgit
pushed a commit
that referenced
this pull request
Aug 25, 2015
…bles In `HiveComparisionTest`s it is possible to fail a query of the form `SELECT * FROM dest1`, where `dest1` is the query that is actually computing the incorrect results. To aid debugging this patch improves the harness to also print these query plans and their results. Author: Michael Armbrust <michael@databricks.com> Closes #8388 from marmbrus/generatedTables. (cherry picked from commit 5175ca0) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
HiveComparisionTests it is possible to fail a query of the formSELECT * FROM dest1, wheredest1is the query that is actually computing the incorrect results. To aid debugging this patch improves the harness to also print these query plans and their results.