-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-10247] [core] improve readability of a test case in DAGSchedulerSuite #8434
Conversation
Can we add some blank line to separate different checks? |
Test build #41561 timed out for PR 8434 at commit |
retest this please |
@squito can you add the suggested blank lines? Otherwise this LGTM. |
Test build #41890 has finished for PR 8434 at commit
|
@andrewor14 added blank lines (and also expanded comments a teeny bit) |
Test build #41935 has finished for PR 8434 at commit
|
retest this please |
Test build #41942 has finished for PR 8434 at commit
|
Merged into master, thanks. |
This is pretty minor, just trying to improve the readability of
DAGSchedulerSuite
, I figure every bit helps. Before whenever I read this test, I never knew what "should work" and "should be ignored" really meant -- this adds some asserts & updates comments to make it more clear. Also some reformatting per a suggestion from @markhamstra on #7699