[SPARK-6028][Core]Remerge #6457: new RPC implemetation and also pick #8905 #8944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e network module"" This reverts commit 02144d6.
|
Test build #43123 has finished for PR 8944 at commit
|
|
Looks like a red flag: I will investigate it. |
|
retest this please |
|
Test build #43177 has finished for PR 8944 at commit
|
|
Test build #43178 has finished for PR 8944 at commit
|
…ncurrent` to `true` `enableConcurrent = true` is in a closure so we should not use `synchronized` directly because that will use the closure itself as the monitor object. The correct monitor object should be the Inbox instance.
|
Test build #43180 has started for PR 8944 at commit |
… is stopped Because `Inbox.stop()` may run before processing `OnStart`, it's possible that `enableConcurrent` will be set to `true` after Inbox is stopped in the previous codes. This is not a correct behavior. This commit just added a check before setting `enableConcurrent` to `true` to fix this issue.
|
Test build #43182 has started for PR 8944 at commit |
|
I looked just at the recent patches, assuming the others just contain the code that had already been reviewed. LGTM pending tests. |
|
retest this please |
|
Test build #43206 has finished for PR 8944 at commit
|
|
I've merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just reverted 02144d6 to remerge #6457 and also included the commits in #8905.