[SPARK-10058][Core][Tests]Fix the flaky tests in HeartbeatReceiverSuite #8946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @andrewor14 |
|
Test build #43127 has finished for PR 8946 at commit
|
| @@ -61,7 +62,12 @@ private[spark] class HeartbeatReceiver(sc: SparkContext, clock: Clock) | |||
| this(sc, new SystemClock) | |||
| } | |||
|
|
|||
| sc.addSparkListener(this) | |||
| if (clock.isInstanceOf[SystemClock]) { | |||
There was a problem hiding this comment.
This is kind of a weird check; I'd favor either some explicit "testMode" boolean parameter to the constructor, or, my preferred, making the test ignore executors that match SparkContext.DRIVER_IDENTIFIER.
There was a problem hiding this comment.
Sounds great. I will update it.
zsxwing
changed the title
|
Test build #43134 has finished for PR 8946 at commit
|
|
retest this please |
|
Test build #43143 has finished for PR 8946 at commit
|
|
LGTM. |
asfgit
pushed a commit
that referenced
this pull request
Oct 1, 2015
…Suite Fixed the test failure here: https://amplab.cs.berkeley.edu/jenkins/view/Spark-QA-Test/job/Spark-1.5-SBT/116/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.2,label=spark-test/testReport/junit/org.apache.spark/HeartbeatReceiverSuite/normal_heartbeat/ This failure is because `HeartbeatReceiverSuite. heartbeatReceiver` may receive `SparkListenerExecutorAdded("driver")` sent from [LocalBackend](https://github.com/apache/spark/blob/8fb3a65cbb714120d612e58ef9d12b0521a83260/core/src/main/scala/org/apache/spark/scheduler/local/LocalBackend.scala#L121). There are other race conditions in `HeartbeatReceiverSuite` because `HeartbeatReceiver.onExecutorAdded` and `HeartbeatReceiver.onExecutorRemoved` are asynchronous. This PR also fixed them. Author: zsxwing <zsxwing@gmail.com> Closes #8946 from zsxwing/SPARK-10058. (cherry picked from commit 9b3e776) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
|
Merged to master and branch-1.5, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the test failure here: https://amplab.cs.berkeley.edu/jenkins/view/Spark-QA-Test/job/Spark-1.5-SBT/116/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.2,label=spark-test/testReport/junit/org.apache.spark/HeartbeatReceiverSuite/normal_heartbeat/
This failure is because
HeartbeatReceiverSuite. heartbeatReceivermay receiveSparkListenerExecutorAdded("driver")sent from LocalBackend.There are other race conditions in
HeartbeatReceiverSuitebecauseHeartbeatReceiver.onExecutorAddedandHeartbeatReceiver.onExecutorRemovedare asynchronous. This PR also fixed them.