[SPARK-10648] Oracle dialect to handle nonspecific numeric types #9495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travishegner
changed the title
|
ok to test |
|
Test build #45118 has finished for PR 9495 at commit
|
| * :: DeveloperApi :: | ||
| * Default Oracle dialect, mapping a nonspecific | ||
| * numeric type to a general decimal type. | ||
| * Solution by @cloud-fan and @bdolbeare (github.com) |
There was a problem hiding this comment.
@travishegner To provide more information, you can provide the links to their comments.
|
Test build #45122 has finished for PR 9495 at commit
|
|
@travishegner I backported your change to branch 1.4 and branch 1.5 (see #9498) with a minor change on comments. Once you update your PR, I will merge it to master. Thanks! |
|
I am merging it to master and branch 1.6. I will update the comments. |
asfgit
pushed a commit
that referenced
this pull request
Nov 5, 2015
This is the alternative/agreed upon solution to PR #8780. Creating an OracleDialect to handle the nonspecific numeric types that can be defined in oracle. Author: Travis Hegner <thegner@trilliumit.com> Closes #9495 from travishegner/OracleDialect. (cherry picked from commit 14ee0f5) Signed-off-by: Yin Huai <yhuai@databricks.com>
|
Thanks @yhuai for taking care of this! |
|
It seems this issue is in OJDBC and started to happen after Oracle 11g: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the alternative/agreed upon solution to PR #8780.
Creating an OracleDialect to handle the nonspecific numeric types that can be defined in oracle.