Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-11290][STREAMING][test-maven] Fix the test for maven build #9668

Closed
wants to merge 1 commit into from
Closed

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Nov 12, 2015

Should not create SparkContext in the constructor of TrackStateRDDSuite. This is a follow up PR for #9256 to fix the test for maven build.

@zsxwing zsxwing changed the title [Hotfix][test-maven] Fix the test for maven build [SPARK-11290][STREAMING][test-maven] Fix the test for maven build Nov 12, 2015
@SparkQA
Copy link

SparkQA commented Nov 12, 2015

Test build #45750 has finished for PR 9668 at commit 7279379.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Nov 12, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Nov 12, 2015

Test build #45754 has finished for PR 9668 at commit 7279379.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Nov 12, 2015

Test build #45768 has finished for PR 9668 at commit 7279379.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Nov 12, 2015

Hm, does it really change the behavior? LGTM in any event. Last failure looks spurious

@tdas
Copy link
Contributor

tdas commented Nov 12, 2015

Yeah, I think so too. The SBT that is testing this was anyways fine. TrackStateByKey seems to passing repeatedly. Let me merge this to master and 1.6. Thanks @zsxwing for catching and fixing this.

asfgit pushed a commit that referenced this pull request Nov 12, 2015
Should not create SparkContext in the constructor of `TrackStateRDDSuite`. This is a follow up PR for #9256 to fix the test for maven build.

Author: Shixiong Zhu <shixiong@databricks.com>

Closes #9668 from zsxwing/hotfix.

(cherry picked from commit f0d3b58)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
@asfgit asfgit closed this in f0d3b58 Nov 12, 2015
@zsxwing zsxwing deleted the hotfix branch November 12, 2015 22:55
dskrvk pushed a commit to dskrvk/spark that referenced this pull request Nov 13, 2015
Should not create SparkContext in the constructor of `TrackStateRDDSuite`. This is a follow up PR for apache#9256 to fix the test for maven build.

Author: Shixiong Zhu <shixiong@databricks.com>

Closes apache#9668 from zsxwing/hotfix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants