[SPARK-11195][CORE] Use correct classloader for TaskResultGetter #9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we are using the context classloader when deserializing failed TaskResults instead of the Spark classloader. Adds a test in TaskResultGetterSuite that compiles a custom exception, throws it on the executor, and asserts that Spark handles the TaskResult deserialization properly.
|
@yhuai any other comments? |
|
ok to test |
|
Test build #46124 has finished for PR 9779 at commit
|
| * Before this fix, enqueueFailedTask would throw a ClassNotFoundException when deserializing | ||
| * the exception, resulting in an UnknownReason for the TaskEndResult. | ||
| */ | ||
| test("failed task deserialized with the correct classloader") { |
There was a problem hiding this comment.
I would put the (SPARK-11195) in the test name to be consistent with other tests.
|
Test build #46192 has finished for PR 9779 at commit
|
|
LGTM. Merging to master and branch 1.6. I will try to cherry-pick it to 1.5. If there is no major conflict, we will not need a 1.5 specific pr. |
|
Thank you for the fix! |
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
Make sure we are using the context classloader when deserializing failed TaskResults instead of the Spark classloader. The issue is that `enqueueFailedTask` was using the incorrect classloader which results in `ClassNotFoundException`. Adds a test in TaskResultGetterSuite that compiles a custom exception, throws it on the executor, and asserts that Spark handles the TaskResult deserialization instead of returning `UnknownReason`. See #9367 for previous comments See SPARK-11195 for a full repro Author: Hurshal Patel <hpatel516@gmail.com> Closes #9779 from choochootrain/spark-11195-master. (cherry picked from commit 3cca5ff) Signed-off-by: Yin Huai <yhuai@databricks.com>
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
Make sure we are using the context classloader when deserializing failed TaskResults instead of the Spark classloader. The issue is that `enqueueFailedTask` was using the incorrect classloader which results in `ClassNotFoundException`. Adds a test in TaskResultGetterSuite that compiles a custom exception, throws it on the executor, and asserts that Spark handles the TaskResult deserialization instead of returning `UnknownReason`. See #9367 for previous comments See SPARK-11195 for a full repro Author: Hurshal Patel <hpatel516@gmail.com> Closes #9779 from choochootrain/spark-11195-master. (cherry picked from commit 3cca5ff) Signed-off-by: Yin Huai <yhuai@databricks.com> Conflicts: core/src/main/scala/org/apache/spark/TestUtils.scala
|
I have merged this PR to branch master, 1.6, and 1.5. There was a minor conflict with 1.5 branch. But, I fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we are using the context classloader when deserializing failed TaskResults instead of the Spark classloader.
The issue is that
enqueueFailedTaskwas using the incorrect classloader which results inClassNotFoundException.Adds a test in TaskResultGetterSuite that compiles a custom exception, throws it on the executor, and asserts that Spark handles the TaskResult deserialization instead of returning
UnknownReason.See #9367 for previous comments
See SPARK-11195 for a full repro