[SPARK-11880][Windows][Spark Submit] bin/load-spark-env.cmd loads spark-env.cmd from wrong directory #9863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk-env.cmd from wrong directory
|
LGTM though how did this ever work then? |
|
Test build #2092 has finished for PR 9863 at commit
|
toddwan
force-pushed
the
master
branch
2 times, most recently
from
c72c9ac
to
094e3e3
Compare
|
I guess users on Windows platform seldom touch |
|
Thanks, merging into master 1.6. |
asfgit
pushed a commit
that referenced
this pull request
Nov 25, 2015
…rk-env.cmd from wrong directory * On windows the `bin/load-spark-env.cmd` tries to load `spark-env.cmd` from `%~dp0..\..\conf`, where `~dp0` points to `bin` and `conf` is only one level up. * Updated `bin/load-spark-env.cmd` to load `spark-env.cmd` from `%~dp0..\conf`, instead of `%~dp0..\..\conf` Author: wangt <wangtao.upc@gmail.com> Closes #9863 from toddwan/master. (cherry picked from commit 9f3e59a) Signed-off-by: Andrew Or <andrew@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/load-spark-env.cmdtries to loadspark-env.cmdfrom%~dp0..\..\conf, where~dp0points tobinandconfis only one level up.bin/load-spark-env.cmdto loadspark-env.cmdfrom%~dp0..\conf, instead of%~dp0..\..\conf