[SPARK-11946][SQL] Audit pivot API for 1.6. #9929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aray |
| // Get the distinct values of the column and sort them so its consistent | ||
| val values = df.select(pivotColumn) | ||
| .distinct() | ||
| .sort(pivotColumn) |
There was a problem hiding this comment.
@aray do you know why we have a "sort" in here?
There was a problem hiding this comment.
The sort is there to ensure that the output columns are in a consistent logical order.
There was a problem hiding this comment.
ok thanks - i'm going to add a comment there to explain.
| @@ -1574,7 +1574,6 @@ class DAGScheduler( | |||
| } | |||
|
|
|||
| def stop() { | |||
| logInfo("Stopping DAGScheduler") | |||
There was a problem hiding this comment.
this is done as part of #9603 (comment) but it is way too small to deserve its own pr.
|
Test build #46591 has finished for PR 9929 at commit
|
| jgd = self._jdf.pivot(_to_java_column(pivot_col), | ||
| _to_seq(self.sql_ctx._sc, values, _create_column_from_literal)) | ||
| if values is None: | ||
| jgd = self._jdf.pivot(pivot_col) |
There was a problem hiding this comment.
Should we use _to_java_column(pivot_col) and _to_seq() here? or df.pivot(df.a) may fail
|
Test build #2104 has finished for PR 9929 at commit
|
|
LGTM |
|
Thanks - merging this in. |
asfgit
pushed a commit
that referenced
this pull request
Nov 24, 2015
Currently pivot's signature looks like ```scala scala.annotation.varargs def pivot(pivotColumn: Column, values: Column*): GroupedData scala.annotation.varargs def pivot(pivotColumn: String, values: Any*): GroupedData ``` I think we can remove the one that takes "Column" types, since callers should always be passing in literals. It'd also be more clear if the values are not varargs, but rather Seq or java.util.List. I also made similar changes for Python. Author: Reynold Xin <rxin@databricks.com> Closes #9929 from rxin/SPARK-11946. (cherry picked from commit f315272) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pivot's signature looks like
I think we can remove the one that takes "Column" types, since callers should always be passing in literals. It'd also be more clear if the values are not varargs, but rather Seq or java.util.List.
I also made similar changes for Python.