[SPARK-11970] [SQL] Add function SHOW to Dataset APIs #9955
Conversation
|
Can you put this together with your join and sample changes? |
| * @param _numRows Number of rows to show | ||
| * @param truncate Whether truncate long strings and align cells right | ||
| */ | ||
| override private[sql] def showString(_numRows: Int, truncate: Boolean = true): String = { |
There was a problem hiding this comment.
can't we share the code between dataset and dataframe?
There was a problem hiding this comment.
When merging them into the same one, I hit a problem when calling the function take. The Dataset API take returns type Array[T], but Dataframe API take has a different return type Array[Row].
Do you have a better idea how to integrate them into the same function?
|
Sure, I can combine them into the same one when you think the implementation of Thank you! |
|
Test build #46662 has finished for PR 9955 at commit
|
|
I implemented show as part of this patch: #9964 I just used toDF().show(). Can you close this pull request? |
|
Yeah, that is also the solution in my original solution in the PR for EXPLAIN. |
Add the function show() to Dataset APIs. The other functions were submitted in separate PRs.
@marmbrus @rxin @cloud-fan Could you help me review the code changes?
Thank you!