Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-11985][STREAMING][KINESIS][DOCS] Update Kinesis docs #9970

Closed
wants to merge 6 commits into from
Closed

[SPARK-11985][STREAMING][KINESIS][DOCS] Update Kinesis docs #9970

wants to merge 6 commits into from

Conversation

brkyvz
Copy link
Contributor

@brkyvz brkyvz commented Nov 25, 2015

  • Provide example on message handler
  • Provide bit on KPL record de-aggregation
  • Fix typos

@SparkQA
Copy link

SparkQA commented Nov 25, 2015

Test build #46684 has finished for PR 9970 at commit d8a5719.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

brkyvz
brkyvz reviewed Nov 25, 2015
View reviewed changes
R/pkg/DESCRIPTION
@@ -36,3 +36,4 @@ Collate:
'stats.R'
'types.R'
'utils.R'
RoxygenNote: 5.0.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just built the docs. Didn't touch this :/

@SparkQA
Copy link

SparkQA commented Nov 25, 2015

Test build #46694 has finished for PR 9970 at commit cec756d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

brkyvz
brkyvz reviewed Nov 25, 2015
View reviewed changes
R/pkg/DESCRIPTION
'column.R'
'group.R'
'RDD.R'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change was probably made while building docs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is generated while building, why is it checked in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. The lines just moved around.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah some versions of roxygen might interpret the order differently or something like that. Its best to leave this file untouched by this PR and we can do a separate PR to bring DESCRIPTION up to date.

@tdas
Copy link
Contributor

tdas commented Nov 26, 2015

Can you put [DOCS] in the title?

@brkyvz brkyvz changed the title [SPARK-11985][STREAMING][KINESIS] Update Kinesis docs [SPARK-11985][STREAMING][KINESIS][DOCS] Update Kinesis docs Nov 26, 2015
@brkyvz
Copy link
Contributor Author

brkyvz commented Nov 30, 2015

@tdas removed SparkR DESCRIPTION file changes

@SparkQA
Copy link

SparkQA commented Nov 30, 2015

Test build #46868 has finished for PR 9970 at commit 948e2ba.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

zsxwing
zsxwing reviewed Dec 14, 2015
View reviewed changes
docs/streaming-kinesis-integration.md
@@ -49,7 +49,7 @@ A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or m
[region name], [initial position], [checkpoint interval], StorageLevel.MEMORY_AND_DISK_2);

See the [API docs](api/java/index.html?org/apache/spark/streaming/kinesis/KinesisUtils.html)
and the [example]({{site.SPARK_GITHUB_URL}}/tree/master/extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java). Refer to the next subsection for instructions to run the example.
and the [example]({{site.SPARK_GITHUB_URL}}/tree/master/extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java). Refer to the Running the Example subsection for instructions to run the example.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a link for Running the Example, such as [Running the Example ](#Running the Example)?

@zsxwing
Copy link
Member

zsxwing commented Dec 16, 2015

@brkyvz could you update this one?

@brkyvz
Copy link
Contributor Author

brkyvz commented Dec 18, 2015

@zsxwing Addressed your comments!

@brkyvz
Copy link
Contributor Author

brkyvz commented Dec 18, 2015

test this please

@SparkQA
Copy link

SparkQA commented Dec 18, 2015

Test build #48033 has finished for PR 9970 at commit 70101e5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 18, 2015

Test build #48035 has finished for PR 9970 at commit 70101e5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Dec 18, 2015

LGTM. Merging to master and 1.6

asfgit pushed a commit that referenced this pull request Dec 18, 2015
@brkyvz @zsxwing
[SPARK-11985][STREAMING][KINESIS][DOCS] Update Kinesis docs
eca401e 
 - Provide example on `message handler`
 - Provide bit on KPL record de-aggregation
 - Fix typos

Author: Burak Yavuz <brkyvz@gmail.com>

Closes #9970 from brkyvz/kinesis-docs.

(cherry picked from commit 2377b70)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
@asfgit asfgit closed this in 2377b70 Dec 18, 2015
@brkyvz brkyvz deleted the kinesis-docs branch February 3, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brkyvz @SparkQA @tdas @zsxwing @shivaram