This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
SQOOP-3435 Avoid NullPointerException due to different JSONObject library in classpath #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szvasas
reviewed
Apr 2, 2019
| @@ -40,6 +40,9 @@ private SqoopJsonUtil() { | |||
| } | |||
|
|
|||
| public static String getJsonStringforMap(Map<String, String> map) { | |||
| if (map == null) { | |||
There was a problem hiding this comment.
Nit: it is a good practice not to reassign the input parameters so I would change this to something like the following:
Map<String, String> mapToUse = (map == null) ? emptyMap() : map; JSONObject pathPartMap = new JSONObject(mapToUse);
There was a problem hiding this comment.
Thanks for your review and suggestion, I have updated the commit and SQOOP-3435
…rary in classpath Sqoop is expecting the classpath to have org.json [1] as the dependency but if one uses HADOOP_CLASSPATH to initialize sqoop executor with com.tdunning open json [2] as the resolution of org.json.JSONObject. it failed with NullPointerException 1. https://mvnrepository.com/artifact/org.json/json/20090211 2. https://github.com/tdunning/open-json/blob/rc1.8/src/main/java/org/json/JSONObject.java#L141-L155
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sqoop is expecting the classpath to have org.json [1] as the dependency
but if one uses HADOOP_CLASSPATH to initialize sqoop executor
with com.tdunning open json [2] as the resolution of org.json.JSONObject.
it failed with NullPointerException