STORM-1492 With nimbus.seeds set to default, a nimbus for localhost may appear "Offline" #1082
Conversation
|
Three builds are failing, which are all intermittent.
Close and reopen to retrigger. |
|
Probability of random test failures becomes very high, though I don't know why. Btw, build fails on storm-hdfs, throwing |
|
I find that when we set That's because the nimbus information saved in zk is CanonicalHostName. But the nimbus seeds we set maybe ip. At last, the nimbus with ip will be 'Offline'.
Change all nimbus-seeds to hostname, before do set/difference, will fix it. |
|
@wuchong Btw, there're more to cover if we want to address this to more ideal way. In result, every nimbuses should know what's the return value of NimbusConf#fromConf for other nimbuses, and every nimbuses should match nimbus.seeds and corresponding values by 1 on 1. Otherwise users should describe the same value which NimbusConf#fromConf will return, for nimbus.seeds. |
…ay appear "Offline" * when determining nimbus addresses from nimbus.seeds, filter out localhost addresses * localhost address: 127.0.0.1, localhost, 0:0:0:0:0:0:0:1 * there may be a chance that nimbus (localhost) is not reachable so we can't get info from alive-nimbuses * but it means ui process itself can't reach nimbus so we can ignore this case * there may be another change that user writes nimbus.seeds both unreachable localhost address and other reachable nimbuses fqdn * ui process can reach other nimbus and localhost itself is lost * but I think we can treat it as configuration error
HeartSaVioR
force-pushed
the
STORM-1492
branch
from
7185442
to
6fbd3d4
Compare
|
@revans2 Thanks for reviewing. Just got rebased against current master. |
|
Still +1 |
…o STORM-1492Q STORM-1492 With nimbus.seeds set to default, a nimbus for localhost may appear "Offline" This closes #1082
First of all, AFAIK, it's just an issue of API output, and it doesn't hurt functionality although we don't fix it.