[STORM-2003] Make sure config contains TOPIC before get it #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| if(stormConf.containsKey(TOPIC)) { | ||
| this.topicSelector = new DefaultTopicSelector((String) stormConf.get(TOPIC)); | ||
| } else { | ||
| throw new IllegalArgumentException("topic select should be specified"); |
There was a problem hiding this comment.
@darionyaphet You may want to have exception's message like below.
'topic' should be specified in bolt's configuration
There was a problem hiding this comment.
@satishd nice advice and fixed
darionyaphet
force-pushed
the
STORM-2003
branch
from
db88029
to
0f8aebd
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STORM-2003 Make sure config contains TOPIC before get it
When topic selector is not specified, KafkaBolt will get topic name from storm config . We should make sure the topic name is not null .