Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-2202 [Storm SQL] Document how to use supported connectors and formats #1777

Merged
merged 1 commit into from
Nov 25, 2016

Conversation

HeartSaVioR
Copy link
Contributor

Copy setting up external data sources to reference page, and add description on data sources (connectors) and formats.

@vesense Since you authored many of them, I'd be happy if you can take a look.

#### CSV

It uses `Standard RFC4180 CSV Parser` and doesn't need any other properties.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor. How about add a link to RFC4180? It is convenient for users who want to look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that would be a good idea. Will address.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

| Redis | org.apache.storm:storm-sql-redis | `redis://:[password]@host:port/[dbIdx]` | No | Yes | Yes
| MongoDB | org.apache.stormg:storm-sql-mongodb | `mongodb://[username:password@]host1[:port1][,host2[:port2],...[,hostN[:portN]]][/[database][?options]]` | No | Yes | Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind this PR including STORM-2082(storm-sql-hdfs, after #1778 getting merged)? I hope storm 1.1.0 include these changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll update when STORM-2082 is merged to master. I'd like to ask you a favor of providing the content for storm-sql-hdfs from #1778 so that I can easily take it.

@vesense
Copy link
Member

vesense commented Nov 15, 2016

Thanks @HeartSaVioR Just two minor comments. Others looks good to me. +1

@HeartSaVioR
Copy link
Contributor Author

I'll merge this now since it doesn't need binding +1 (documentation) and @vesense confirms it's OK.

@asfgit asfgit merged commit 957fcab into apache:master Nov 25, 2016
@HeartSaVioR HeartSaVioR deleted the STORM-2202 branch June 29, 2017 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants