-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STORM-2202 [Storm SQL] Document how to use supported connectors and formats #1777
Conversation
#### CSV | ||
|
||
It uses `Standard RFC4180 CSV Parser` and doesn't need any other properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor. How about add a link to RFC4180? It is convenient for users who want to look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that would be a good idea. Will address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
| Redis | org.apache.storm:storm-sql-redis | `redis://:[password]@host:port/[dbIdx]` | No | Yes | Yes | ||
| MongoDB | org.apache.stormg:storm-sql-mongodb | `mongodb://[username:password@]host1[:port1][,host2[:port2],...[,hostN[:portN]]][/[database][?options]]` | No | Yes | Yes | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind this PR including STORM-2082(storm-sql-hdfs, after #1778 getting merged)? I hope storm 1.1.0 include these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I'll update when STORM-2082 is merged to master. I'd like to ask you a favor of providing the content for storm-sql-hdfs from #1778 so that I can easily take it.
Thanks @HeartSaVioR Just two minor comments. Others looks good to me. +1 |
102bb13
to
1b3848d
Compare
1b3848d
to
957fcab
Compare
I'll merge this now since it doesn't need binding +1 (documentation) and @vesense confirms it's OK. |
Copy setting up external data sources to reference page, and add description on data sources (connectors) and formats.
@vesense Since you authored many of them, I'd be happy if you can take a look.