STORM-2244 Some shaded jars doesn't exclude dependency signature files #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeartSaVioR
commented
Dec 18, 2016
HeartSaVioR
commented
- Add filter option to all of shade plugin configurations
* Add filter option to all of shade plugin configurations
srdo
reviewed
Dec 20, 2016
| @@ -62,6 +62,23 @@ | |||
| <artifactId>maven-shade-plugin</artifactId> | |||
| <configuration> | |||
| <createDependencyReducedPom>true</createDependencyReducedPom> | |||
| <filters> | |||
There was a problem hiding this comment.
I'm wondering if it would work to put this in PluginManagement in the root pom instead?
|
+1 |
1 similar comment
|
+1 |
|
@HeartSaVioR can you open a PR for 1.x-branch as well. |
|
@harshach Just missed this. I'll create pull request against 1.x branch soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.