STORM-2038: Disable symlinks with a config option #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
reviewed
Mar 7, 2017
| @@ -341,6 +344,9 @@ public String slurpString(File location) throws IOException { | |||
| * @throws IOException on any error. | |||
| */ | |||
| public void createSymlink(File link, File target) throws IOException { | |||
| if (_symlinksDisabled) { | |||
| throw new IOException("Symlinks have been disabled, this hsould not be called"); | |||
|
Applied the option and submit topology to remote cluster. +1 @revans2 Great work. Could you resolve conflict? And please create pull requests for 1.x and 1.0.x. |
revans2
force-pushed
the
STORM-2038-sym-link-alternative
branch
from
3a0758b
to
b000a98
Compare
|
@HeartSaVioR I have rebased the changes to remove the conflict (it was just in the documentation). I'll start working on backporting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #1972 but I have not ported it to other branches yet, so I would like to keep the two separate. Once reviews are done on this version I will port it to 1.x and 1.0.x (as it apparently is a real pain for windows users)