-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STORM-2038: Disable symlinks with a config option #1974
STORM-2038: Disable symlinks with a config option #1974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one nit for exception message but looks great overall.
Maybe need to test with option off before giving +1.
@@ -341,6 +344,9 @@ public String slurpString(File location) throws IOException { | |||
* @throws IOException on any error. | |||
*/ | |||
public void createSymlink(File link, File target) throws IOException { | |||
if (_symlinksDisabled) { | |||
throw new IOException("Symlinks have been disabled, this hsould not be called"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hsould -> should
Applied the option and submit topology to remote cluster. +1 @revans2 Great work. Could you resolve conflict? And please create pull requests for 1.x and 1.0.x. |
3a0758b
to
b000a98
Compare
@HeartSaVioR I have rebased the changes to remove the conflict (it was just in the documentation). I'll start working on backporting it. |
This is built on top of #1972 but I have not ported it to other branches yet, so I would like to keep the two separate. Once reviews are done on this version I will port it to 1.x and 1.0.x (as it apparently is a real pain for windows users)