[STORM-2455] Expose the window start and end timestamp in TupleWindow #2053
Conversation
|
@arunmahadevan this looks like backward incompatible change? |
|
@harshach, the earlier change (that added getTimestamp) was checked in to only the master branch. Since its not part of any released versions of Storm may be its not an issue if we can get this merged before the 2.0 release? |
| @@ -47,9 +47,17 @@ | |||
| List<T> getExpired(); | |||
|
|
|||
| /** | |||
| * If processing based on event time, returns the watermark time otherwise the current timestamp. | |||
| * If processing based on event time, returns the window end time based on watermark otherwise | |||
| * returns the current timestamp. | |||
There was a problem hiding this comment.
Returning the current timestamp(at which this method is invoked) for non event-timestamp scenarios does not look to be intuitive. Users may assume endTimeStamp should return the timestamp at which the window is completed.
There was a problem hiding this comment.
Thanks for noticing. Its actually returning the timestamp at which window ends for both event and processing time. I am invoking System.currentTimeMillis in getEndTimestamp which is un-necessary. Will reword the doc and refactor a bit to make it clear.
arunmahadevan
force-pushed
the
STORM-2455
branch
from
39f8bb5
to
bf0f9bb
Compare
|
+1 |
|
+1 LGTM |
No description provided.