STORM-2516: Fix timing issues with testPrepareLateTupleStreamWithoutB… #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdo
force-pushed
the
STORM-2516
branch
2 times, most recently
from
a28bd8f
to
76776d6
Compare
| @@ -45,17 +46,25 @@ | |||
| private final Map<GlobalStreamId, Long> streamToTs; | |||
| private final ScheduledExecutorService executorService; | |||
| private final int interval; | |||
| private final AtomicLong lastWaterMarkTs; | |||
There was a problem hiding this comment.
this could be a volatile instead of AtomicLong
There was a problem hiding this comment.
Yes. Why do you prefer volatile? (I'll be happy to change it, I'm just wondering if there's a drawback to using AtomicX)
There was a problem hiding this comment.
It doesn't make much difference except the extra overhead of the AtomicLong object and we don't require the additional atomic operations from AtomicLong.
There was a problem hiding this comment.
Replaced with volatile
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uilder
The test was sleeping a bit and hoping that WaterMarkEventGenerator.run() had been run by the executor in that class before the test woke up. Sometimes that wasn't happening. Instead we're calling the method manually now, like the rest of the tests involving that class.
I also fixed the checkstyle violations in WaterMarkEventGenerator.
As far as I can tell, the lastWatermarkTs variable in WaterMarkEventGenerator should be volatile or an AtomicLong, since it is being written to in run() with the expectation that it can be seen by the thread calling track().