STORM-2799: Exclude jdk.tools for JDK 9 compatibility #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure seems unrelated. I've run the tests a few times on JDK 8 and haven't been able to reproduce the failure. |
|
The changes look fine, but the test failure is something I have been seeing quite a bit recently, but only on travis. I think it must be a race condition. I am going to file a JIRA for it, but I have no idea when I will have time to look into it. |
asfgit
pushed a commit
that referenced
this pull request
Nov 7, 2017
…-2799 STORM-2799: Exclude jdk.tools for JDK 9 compatibility This closes #2401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/STORM-2799.
This excludes jdk.tools from a few dependencies. I also upgraded hbase to the latest patch release of the current version, since the 1.1.0 version leaks jdk.tools https://issues.apache.org/jira/browse/HBASE-13963 and versions prior to 1.1.11 don't work with Java 9 https://issues.apache.org/jira/browse/HBASE-17944.